-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] run test with coverage command #37
Conversation
Fixed command in GitHub workflow.
WalkthroughThe pull request modifies the GitHub Actions workflow file to adjust the coverage reporting path. The change simplifies the coverage source path by removing the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/test-and-publish.yaml (1)
64-64
: Consider consolidating test coverage reportingThe workflow currently has two separate test executions:
- In the test job with coverage
- In the publish job without coverage
Consider adding coverage reporting to the publish job's test execution as well to maintain consistency and provide coverage data for released versions.
Apply this diff to add coverage reporting to the publish job:
- name: Test package - run: pytest tests/ + run: | + python -m pytest tests/ --cov=pkynetics --cov-report=xml --junitxml=junit.xml
⚡ Have you read the Contributing Guidelines?
Description
Updated GitHub Actions workflow test command to correctly specify package name for coverage reporting, ensuring accurate Codecov badge and test coverage information.
Type of Change
Checklist
black
(line length 100)isort
for import sorting