Use waitForTaskToken for Fargate tasks #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farski
commented
Jan 6, 2026
| raise StandardError, "FFmpeg probe failed" unless system ffprobe_cmd | ||
|
|
||
| # Write the probe output to S3 | ||
| puts "Writing probe output to S3 artifact bucket" |
Member
Author
farski
commented
Jan 6, 2026
| ErrorMessage: e.message | ||
| }) | ||
| ) | ||
| sf.send_task_failure({ |
Member
Author
There was a problem hiding this comment.
Compare to the old way, which caused Lambda executions to fail to force the FTP issue to be treated as a task failure. Now we do that directly.
cavis
approved these changes
Jan 13, 2026
Member
cavis
left a comment
cavis
left a comment
There was a problem hiding this comment.
One comment on the bytes (float vs int), but otherwise looks good to me.
| # Add the probe results for this output to the task result | ||
| probe_results = JSON.parse(stdout) | ||
| task_result[:Duration] = probe_results["format"]["duration"].to_f * 1000 | ||
| task_result[:Size] = probe_results["format"]["size"].to_f |
Member
There was a problem hiding this comment.
Probably .to_i? I don't know if it would break anything, but was just an integer before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would do something in synchronous Fargate tasks, which have no capacity for passing data back to the state machine.
This changes to using a async
waitForTaskTokenconfig, which allows the Fargate task to pass arbitrary data back to the state machine upon completion. These negates the previous need to write similar data to S3, and then immediately read that data back from S3 in a Lambda function, just to make it available within the state machine.The main thing to review here is ensuring that the
outputofsend_task_successthat's now happening within the Fargate code matches the previous result of the now-removed-task-outputLambda functions. And thatsend_task_failureis being used in a way that makes sense.The
FtpCopyTaskOutputLambdaErrorAlarmalarm has also been removed, since it was based on the now-removed function, and we've decided there's no need to find an alternative.Closes #183