reduced 30% time by changing 2d vectors to cv::Mat #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @k-okada , apologies for removing it (and making it more difficult for you), but i was not quite happy with it at that time (unresolved bugs in the connectivity, inconsistant color handling), also opencv added an own reimplementation of SLIC/O (in opencv_contrib) but glad to see, you found it useful, and good luck with this ! |
|
On Tue, Aug 30, 2016 at 7:28 PM, berak notifications@github.com wrote:
Oh, I didn't know that, Thanks for info!!! ◉ Kei Okada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're using https://github.com/garaemon/SLIC-Superpixels and noticed that @berak's branch was disappeared,
This PR is consists of several his/her contribution of "reduced 30% time by changing 2d vectors to cv::Mat"
This PR is build upon #4