fix: amm-2061 admin work location mapping issue fixed

[5Amogh]

📋 Description

JIRA ID: amm-2061

admin work location mapping issue fixed

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)

Summary by CodeRabbit

• Bug Fixes
  • Enhanced work location block selection behavior to prevent unexpected updates triggered by background system processes and automatic selection changes. The interface now responds exclusively to your direct user interactions, eliminating unintended modifications and providing a more reliable, predictable experience when managing, configuring, and maintaining your work location mappings and related assignments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A click event handler on an edit block selection option is replaced with an onSelectionChange handler that includes a guard condition ($event.isUserInput) to ensure only user-initiated selections trigger the setUpdatedBlockName update, preventing unintended programmatic selection changes.

Changes

Cohort / File(s)	Summary
Work Location Mapping Template src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.html	Replaced click event handler with onSelectionChange handler; added guard condition to filter out programmatic selections and only process user-initiated changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A guard stands tall at selection's gate,
User clicks flow through, programmatic ones wait,
isUserInput checks with care,
No unwanted updates in the air!
*~CodeRabbit

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the specific issue (amm-2061) and describes the main change (work location mapping issue fixed), directly relating to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.html (1)

736-738: Good fix for preventing programmatic updates, but consider consolidating logic.

The $event.isUserInput guard correctly prevents setUpdatedBlockName from being called during programmatic selection changes, which addresses the bug. However, this splits the block selection logic between the mat-select (line 729) and individual mat-option elements.

♻️ Optional refactor to consolidate logic on mat-select

Consider moving the block name capture to the mat-select's selectionChange handler to centralize the logic:

At line 729, update the mat-select handler:

-                (selectionChange)="getEditVillageMaster(ServiceEditblock)"
+                (selectionChange)="
+                  getEditVillageMaster(ServiceEditblock);
+                  setUpdatedBlockName(
+                    editblocks.find(b => b.blockID === ServiceEditblock)?.blockName
+                  )
+                "

Then remove the onSelectionChange from mat-option:

                <mat-option
                  *ngFor="let item of editblocks"
                  [value]="item.blockID"
-                  (onSelectionChange)="
-                    $event.isUserInput && setUpdatedBlockName(item.blockName)
-                  "
                >

This centralizes selection handling and eliminates the need for the isUserInput guard since mat-select's selectionChange only fires for actual value changes.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66872f4 and 25b2a07.

📒 Files selected for processing (1)

• src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.html

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2024-11-25T11:01:28.621Z

Learnt from: devikasuresh20
Repo: PSMRI/ADMIN-UI PR: 50
File: src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.ts:1981-1981
Timestamp: 2024-11-25T11:01:28.621Z
Learning: In the `filterComponentList` method of `WorkLocationMappingComponent` in `src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.ts`, retain the manual filtering implementation as it provides better control over the filtering logic.

Applied to files:

• src/app/app-provider-admin/provider-admin/activities/work-location-mapping/work-location-mapping.component.html