Skip to content

Bugfix/issue 58 : Fix Build Issues & Add Submodule Support in GitHub Actions CI #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drtechie merged 3 commits into from
Apr 7, 2025
Merged

Bugfix/issue 58 : Fix Build Issues & Add Submodule Support in GitHub Actions CI #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e397c72
fix(script) : added prebuild command to create environment to run the…
abhijeetw035 Apr 3, 2025
765fdc2
fix : Enable submodule checkout and update in CI workflow
abhijeetw035 Apr 3, 2025
41193d1
fix(script): added a build-ci in workflows and removed prebuild command
abhijeetw035 Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/build-on-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ jobs:
Build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
- name: Checkout code with submodules
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
submodules: true

- name: Update submodules manually (if needed)
run: |
git submodule init
git submodule update --recursive

- name: Setup JDK 17
uses: actions/setup-java@v2
Expand All @@ -33,4 +39,4 @@ jobs:
npm install ng2-smart-table@1.2.1
npm install node-sass
npm install --force
npm run build
npm run build-ci
2 changes: 1 addition & 1 deletion .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: jar -cvf admin-ui.war -C dist .

- name: Upload WAR file as artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
Copy link
Member

@drtechie drtechie Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijeetw035 guess you have to use v4.
v3 is deprecated.

Copy link
Contributor Author

@abhijeetw035 abhijeetw035 Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @drtechie, should raise new PR on ADMIN-UI that updates all action's versions?

with:
name: ADMIN-UI
path: admin-ui.war