Migration/2079

[SauravBizbRolly]

📋 Description

JIRA ID: AMM-2079

Add new column

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• Chores
  • Updated data schema to add fields capturing village name, counts of Auxiliary Nurse Midwife/Multi-Purpose Worker and Anganwadi Worker attendees, counts of pregnant women and lactating mothers, number of committee members present, and previous meeting follow-up notes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@SauravBizbRolly has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7d0823f and 8e42928.

📒 Files selected for processing (1)

• src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql

📝 Walkthrough

Walkthrough

Adds a SQL migration that conditionally appends seven new columns to the db_iemr.vhnc_form table using INFORMATION_SCHEMA existence checks and dynamic prepared ALTER TABLE statements; the script runs under USE db_iemr; and executes per-column PREPARE/EXECUTE/DEALLOCATE sequences.

Changes

Cohort / File(s)

Summary

Database Schema Migration src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql

Adds seven columns to vhnc_form with per-column existence checks via INFORMATION_SCHEMA.COLUMNS and dynamic PREPARE/EXECUTE ALTER TABLE: village_name (VARCHAR(255)), auxiliary_nurse_midwife_multipurpose_worker_attended (INT DEFAULT 0), anganwadi_worker_attended (INT DEFAULT 0), pregnant_women_count (INT DEFAULT 0), lactating_mothers_count (INT DEFAULT 0), committee_members_present (INT DEFAULT 0), previous_meeting_followup (TEXT). Uses USE db_iemr;. No data migration beyond adding columns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through rows and fields tonight,

Planted seven columns, tidy and bright,
Villages and counts in careful array,
Notes from meetings now find their way,
A little hop for schema delight.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Migration/2079' is too vague and generic. It references a ticket number but provides no meaningful information about what columns are being added or what the migration accomplishes.	Use a more descriptive title that summarizes the actual change, such as 'Add columns to vhnc_form table for meeting tracking' or 'Migration: Add village name and attendance tracking columns to vhnc_form'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In @src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql:
- Around line 6-7: The migration contains misspelled column names; update the
ADD COLUMN statements to use the correct names: replace no_of_pragnent_women
with no_of_pregnant_women and replace no_of_lacting_mother with
no_of_lactating_mothers in the V38__DB_IEMR_AMM_2079.sql migration, keeping the
INT type and any surrounding commas/SQL syntax intact; also search for any
subsequent references in the same migration (constraints, indexes, inserts) that
use the old identifiers and update them to the corrected column names to avoid
runtime errors.

🧹 Nitpick comments (2)

src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql (2)

1-2: Consider removing redundant database qualification.

The USE db_iemr; statement already sets the database context, making the db_iemr. prefix on Line 2 redundant. You can simplify to just ALTER TABLE vhnc_form.

♻️ Proposed simplification

 USE db_iemr;
-ALTER TABLE db_iemr.vhnc_form
+ALTER TABLE vhnc_form
     ADD COLUMN village_name VARCHAR(255),
     ADD COLUMN anm INT,
     ADD COLUMN aww INT,

---

2-9: Consider NULL constraints and indexing strategy.

All new columns are implicitly NULL-able. Consider:

1. NULL constraints: Should any of these fields be required? If so, add NOT NULL constraints with appropriate defaults.
2. Indexing: If village_name will be frequently used in WHERE clauses or JOINs, consider adding an index for query performance.
3. Data validation: Consider adding CHECK constraints for count columns to ensure non-negative values (e.g., CHECK (no_of_pregnant_women >= 0)).

Example for adding constraints:

ALTER TABLE vhnc_form
    ADD COLUMN village_name VARCHAR(255),
    ADD COLUMN anm INT CHECK (anm >= 0),
    ADD COLUMN aww INT CHECK (aww >= 0),
    -- etc.

If indexing is needed:

CREATE INDEX idx_vhnc_form_village_name ON vhnc_form(village_name);

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b8a0c2 and ac5dcf6.

📒 Files selected for processing (1)

• src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (java)

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/main/resources/db/migration/dbiemr/V38__DB_IEMR_AMM_2079.sql`:
- Around line 1-21: The dynamic ALTER TABLE in the `@preparedStatement` CONCAT
uses COMMENT "..." which breaks under ANSI_QUOTES; update the CONCAT that builds
the ALTER TABLE (the `@preparedStatement` assignment) to use a single-quoted
COMMENT literal instead of double quotes and escape it correctly inside the
single-quoted SQL string (i.e. replace COMMENT "Village name where meeting held"
with COMMENT 'Village name where meeting held', using doubled single quotes if
nested inside a single-quoted literal in the CONCAT).