-
Notifications
You must be signed in to change notification settings - Fork 14
AMM-2128 new table for tb confirmed cases #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AMM-2128 new table for tb confirmed cases #82
Conversation
📝 WalkthroughWalkthroughA new SQL migration file is added that creates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/resources/db/migration/dbiemr/V41__TB_conformed_cases_DB_IEMR.sql`:
- Line 3: The migration filename contains a misspelling ("conformed") that
doesn't match the created table `tb_confirmed_cases`; rename the migration file
V41__TB_conformed_cases_DB_IEMR.sql to V41__TB_confirmed_cases_DB_IEMR.sql so it
accurately reflects the table name, and update any references to the old
filename in your migration tooling or documentation (and re-run checks or adjust
any stored checksums if your migration system tracks filenames).
🧹 Nitpick comments (2)
src/main/resources/db/migration/dbiemr/V41__TB_conformed_cases_DB_IEMR.sql (2)
1-1: Avoid hard‑coding the schema in migrations.Using
USE db_iemr;can break deployments where the migration runner sets the schema or where the DB user lacksUSEprivileges. Prefer relying on the configured schema unless this is a repo-wide convention.✅ Suggested change
-USE db_iemr; -
5-22: Confirm referential integrity strategy forben_idanduser_id.If these columns reference parent tables, consider adding FK constraints (or explicitly documenting that integrity is enforced at the application layer) to avoid orphaned records.
| @@ -0,0 +1,34 @@ | |||
| USE db_iemr; | |||
|
|
|||
| CREATE TABLE IF NOT EXISTS `tb_confirmed_cases` ( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align migration filename spelling with the table name.
The migration file says “conformed” while the table is “confirmed.” Consider renaming the migration to match for clarity and future traceability.
🤖 Prompt for AI Agents
In `@src/main/resources/db/migration/dbiemr/V41__TB_conformed_cases_DB_IEMR.sql`
at line 3, The migration filename contains a misspelling ("conformed") that
doesn't match the created table `tb_confirmed_cases`; rename the migration file
V41__TB_conformed_cases_DB_IEMR.sql to V41__TB_confirmed_cases_DB_IEMR.sql so it
accurately reflects the table name, and update any references to the old
filename in your migration tooling or documentation (and re-run checks or adjust
any stored checksums if your migration system tracks filenames).



📋 Description
JIRA ID: AMM-2128
new table for tb confirmed cases
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.