AMM-1456 fix: cookie name #204
Conversation
WalkthroughThe change updates the logic in the Changes
Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java (1)
495-505: Consider extracting duplicated cookie lookup logic.This cookie lookup logic is duplicated in the
getJwtTokenFromCookiemethod (lines 1093-1101). Consider extracting this into a helper method to follow DRY principles.+private String extractJwtTokenFromCookies(Cookie[] cookies) { + if (cookies != null) { + for (Cookie cookie : cookies) { + if ("Jwttoken".equalsIgnoreCase(cookie.getName())) { + return cookie.getValue(); + } + } + } + return null; +}Then use it in both methods:
- if (jwtToken == null) { - Cookie[] cookies = request.getCookies(); - if (cookies != null) { - for (Cookie cookie : cookies) { - if ("Jwttoken".equalsIgnoreCase(cookie.getName())) { - jwtToken = cookie.getValue(); - break; - } - } - } - } + if (jwtToken == null) { + jwtToken = extractJwtTokenFromCookies(request.getCookies()); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: style-check / checkstyle
- GitHub Check: Analyze (java)
- GitHub Check: Package-test
- GitHub Check: Build
| if (cookies != null) { | ||
| for (Cookie cookie : cookies) { | ||
| if ("jwtToken".equals(cookie.getName())) { | ||
| if ("Jwttoken".equalsIgnoreCase(cookie.getName())) { |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Good fix for case-sensitivity, but verify cookie name consistency.
The change to use equalsIgnoreCase() is a good practice for robust cookie handling. However, please ensure that the cookie name "Jwttoken" exactly matches how the cookie is set elsewhere in the application.
Let me verify the cookie naming consistency across the codebase:
🏁 Script executed:
#!/bin/bash
# Description: Check for JWT cookie naming patterns to ensure consistency
# Search for cookie setting operations
echo "=== Cookie Setting Operations ==="
rg -A 3 -B 3 "addJwtTokenToCookie|setCookie|addCookie" --type java
# Search for JWT token cookie references
echo "=== JWT Token Cookie References ==="
rg -A 2 -B 2 "jwtToken|Jwttoken|JWT.*[Cc]ookie" --type java
# Search in CookieUtil to see how the cookie is actually named
echo "=== CookieUtil Implementation ==="
fd "CookieUtil" --type f --extension java --exec cat {}Length of output: 17692
Approve case‐insensitive cookie comparison; cookie name is consistent.
All JWT cookies are consistently named "Jwttoken" when set and read. To eliminate duplicated lookup logic, please refactor the manual loops to use the existing utility method:
• src/main/java/com/iemr/common/controller/users/IEMRAdminController.java
– Line 499 in getLoginResponse (manual cookie loop)
– getJwtTokenFromCookie endpoint (around line 1095)
• src/main/java/com/iemr/common/utils/JwtUserIdValidationFilter.java
– Cookie lookup block using equalsIgnoreCase("Jwttoken")
Replace each manual loop with a call to CookieUtil.getJwtTokenFromCookie(request) for better DRY and consistency.
🤖 Prompt for AI Agents
In src/main/java/com/iemr/common/controller/users/IEMRAdminController.java at
line 499, the manual loop checking for the "Jwttoken" cookie using
equalsIgnoreCase should be refactored to use the existing utility method
CookieUtil.getJwtTokenFromCookie(request). This change will remove duplicated
cookie lookup logic, improve code consistency, and adhere to DRY principles.
Locate all manual cookie loops for JWT token retrieval in this file and in
JwtUserIdValidationFilter.java and replace them with calls to
CookieUtil.getJwtTokenFromCookie(request).
📋 Description
JIRA ID: AMM-1456
Ensure cookie is correctly checked in login response API
✅ Type of Change
Summary by CodeRabbit