Skip to content

fix: drive is production with a env variable #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishwab1 merged 1 commit into from
Jun 18, 2025
Merged

fix: drive is production with a env variable #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/main/environment/common_ci.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ springdoc.api-docs.enabled=false
springdoc.swagger-ui.enabled=false


isProduction=true
isProduction=@env.IS_PRODUCTION@
grievanceAllocationRetryConfiguration=3

start-grievancedatasync-scheduler=false
Expand All @@ -177,10 +177,7 @@ captcha.secret-key=@env.CAPTCHA_SECRET_KEY@
captcha.verify-url=@env.CAPTCHA_VERIFY_URL@
captcha.enable-captcha=@env.ENABLE_CAPTCHA@

<<<<<<< HEAD
=======
cors.allowed-origins=@env.CORS_ALLOWED_ORIGINS@


>>>>>>> develop

2 changes: 1 addition & 1 deletion src/main/environment/common_docker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ springdoc.api-docs.enabled=false
springdoc.swagger-ui.enabled=false


isProduction=true
isProduction=${IS_PRODUCTION}
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Validate IS_PRODUCTION placeholder with default fallback
To prevent startup failures when IS_PRODUCTION isn’t set, specify a sensible default (e.g., false).

-isProduction=${IS_PRODUCTION}
+isProduction=${IS_PRODUCTION:false}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
isProduction=${IS_PRODUCTION}
-isProduction=${IS_PRODUCTION}
+isProduction=${IS_PRODUCTION:false}
🤖 Prompt for AI Agents 
In src/main/environment/common_docker.properties at line 171, the IS_PRODUCTION
placeholder is used without a default value, which can cause startup failures if
the environment variable is not set. Modify the line to provide a default
fallback value, such as false, by using the syntax for default values in
properties files to ensure the application starts reliably even when
IS_PRODUCTION is undefined.

grievanceAllocationRetryConfiguration=3

start-grievancedatasync-scheduler=false
Expand Down
Loading