[HOLD - do not merge] fix: add missing env variables for scheduler #231
Conversation
WalkthroughNew scheduler configuration properties have been appended to the application properties file. Three schedulers are introduced, each with an enable flag and a cron expression specifying their execution times. No existing configurations or code logic are changed; only new property entries are added. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/application.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (java)
- GitHub Check: Build
- GitHub Check: Package-test
| ##-------------------------------###cti data check with call detail report Scheduler------------------------------------------------------ | ||
|
|
||
| #Runs at everyday 12:10AM | ||
| start-ctidatacheck-scheduler=true | ||
| cron-scheduler-ctidatacheck=0 00 02 * * * | ||
|
|
There was a problem hiding this comment.
Incorrect cron field count & comment mismatch for CTI data check scheduler
The line cron-scheduler-ctidatacheck=0 00 02 * * * uses a 6-field cron (missing the day-of-week placeholder) and conflicts with the comment “Runs at everyday 12:10 AM.” For Quartz compatibility, use 7 fields with ? for day-of-week (e.g., 0 10 00 * * ? * for 12:10 AM) or align both the cron and comment to the intended time.
🤖 Prompt for AI Agents
In src/main/resources/application.properties around lines 183 to 188, the cron
expression for ctidatacheck scheduler uses 6 fields instead of the required 7
for Quartz and does not match the comment time of 12:10 AM. Update the cron
expression to have 7 fields with a '?' for day-of-week, for example, '0 10 0 * *
? *' to run at 12:10 AM daily, or adjust the comment to match the actual cron
time if you want to keep the current schedule.
|
|
||
| ##-------------------------------###cti data sync Scheduler configurations------------------------------------------------------ | ||
|
|
||
| #Runs at every alternative days at 2AM | ||
| start-ctidatasync-scheduler=true | ||
| cron-scheduler-ctidatasync=0 30 01 * * ? * | ||
|
|
There was a problem hiding this comment.
Mismatch between cron and description for CTI data sync scheduler
The cron expression 0 30 01 * * ? * schedules a job daily at 1:30 AM—not every other day at 2 AM as the comment suggests. Update either the cron pattern (e.g., 0 30 01 1/2 * ? * for alternate days at 1:30 AM) or correct the comment/time details.
🤖 Prompt for AI Agents
In src/main/resources/application.properties around lines 176 to 182, the
comment states the CTI data sync scheduler runs every other day at 2 AM, but the
cron expression schedules it daily at 1:30 AM. To fix this, either update the
cron expression to run every other day at the intended time (e.g., use a pattern
like '0 0 2 1/2 * ? *' for 2 AM every other day) or adjust the comment to
accurately reflect the current cron schedule.
| ##-----------------------------------------------#NHM data dashboard schedular---------------------------------------------------------------- | ||
| # run at everyday 12:01AM | ||
| start-nhmdashboard-scheduler=true | ||
| cron-scheduler-nhmdashboard=0 30 0 * * ? * |
There was a problem hiding this comment.
Typo and mismatch in NHM data dashboard scheduler config
The comment “run at everyday 12:01 AM” does not match the cron 0 30 0 * * ? * (12:30 AM). Also, fix “schedular” → “scheduler” for clarity. Update the cron or comment to the correct time and correct the spelling.
🤖 Prompt for AI Agents
In src/main/resources/application.properties around lines 190 to 193, correct
the typo "schedular" to "scheduler" in the comment. Also, ensure the comment
time matches the cron expression: either update the comment to say "run at
everyday 12:30 AM" to match the cron "0 30 0 * * ? *" or change the cron to "0 1
0 * * ? *" if the intended time is 12:01 AM.
drtechie
changed the title
📋 Description
JIRA ID: NA
Add missing env variables.
✅ Type of Change
Summary by CodeRabbit