Unallocate changes

[ravishanigarapu]

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• Refactor
  • Improved call status and allocation logic for language mapping and call types, streamlining conditions and reducing redundancy.
  • Consolidated handling of call allocation for specific roles, simplifying the process for retrieving allocated records.
• Style
  • Minor whitespace cleanup for better readability.

[coderabbitai]

Walkthrough

The changes refactor logic in the call closure and call allocation services. In call closure, language mapping and call type checks are consolidated and expanded for resetting allocation status. In call allocation, special handling for the "MO" role is removed, consolidating record retrieval to generic methods for all roles.

Changes

File(s)	Change Summary
src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java	Refactored and consolidated language mapping and call type checks in closeCall; expanded allocation reset logic; minor cleanup.
src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java	Removed "MO" role-specific branches in moveAllocatedCallsToBin; now uses generic record retrieval methods for all roles.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CallClosureService
    participant Repository

    User->>CallClosureService: closeCall(request)
    CallClosureService->>CallClosureService: Check language mapping and call type
    alt Not mapped & "introductory" or ANM
        CallClosureService->>Repository: Reset allocation status, call status, user ID, attempts
    end
    CallClosureService->>Repository: Update further call requirement if flag is non-null
    CallClosureService-->>User: Return response

Loading

sequenceDiagram
    participant System
    participant CallAllocationService
    participant Repository

    System->>CallAllocationService: moveAllocatedCallsToBin(role, recordType)
    alt Any role (including "MO")
        CallAllocationService->>Repository: getAllocatedRecordsUserByRecordTypeAndPhoneTypeMother/Child
    end
    CallAllocationService-->>System: Complete bin movement

Loading

Possibly related PRs

• PSMRI/ECD-API#84: Refactors allocation resetting logic for "introductory" call types in CallClosureImpl.closeCall, directly related to similar logic changes.
• PSMRI/ECD-API#71: Adds and later removes "MO"-specific repository method calls in moveAllocatedCallsToBin, directly connected to the current consolidation.
• PSMRI/ECD-API#92: Makes nearly identical changes to language mapping and allocation reset logic in CallClosureImpl.closeCall.

Suggested reviewers

• helenKaryamsetty
• mo839639

Poem

In the garden of code where the calls hop along,
Roles and languages now sing a simpler song.
"MO" blends in with the rest of the crew,
While closure checks are streamlined anew.
With every refactor, the logic grows neat—
A rabbit’s delight in a codebase complete! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d480be and 58a9826.

📒 Files selected for processing (2)

• src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (3 hunks)
• src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (1)

src/main/java/com/iemr/ecd/utils/constants/Constants.java (1)

• Constants (5-24)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java)

🔇 Additional comments (3)

src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (3)

195-195: LGTM: Good refactoring to eliminate redundant calls.

The consolidation of isLanguageMappedWithUser(request) into a single call improves performance by avoiding duplicate method execution.

---

197-202:

Details

❓ Verification inconclusive

Verify the expanded condition logic for allocation status reset.

The condition has been expanded to include both ANM role and introductory call types. This means allocation status will be reset for:

1. ANM role calls (existing behavior)
2. Introductory call types (new behavior)

Please verify that resetting allocation status for all introductory calls is the intended behavior, as this could impact call routing logic.

---

🏁 Script executed:

#!/bin/bash
# Description: Search for other references to introductory call type handling to understand the impact
# Expected: Find other places where introductory calls are handled to verify consistency

echo "=== Searching for introductory call type handling ==="
rg -A 5 -B 5 "introductory.*equalsIgnoreCase|equalsIgnoreCase.*introductory"

echo "=== Searching for allocation status reset patterns ==="
rg -A 3 -B 3 "setAllocationStatus.*UNALLOCATED|UNALLOCATED.*setAllocationStatus"

Length of output: 9581

---

Verify allocation reset for introductory calls

The updated condition in src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (lines 197–202) now includes callObj.getEcdCallType().equalsIgnoreCase("introductory"), causing callObj.setAllocationStatus(Constants.UNALLOCATED) to fire for all introductory calls when a preferred language is provided and not yet mapped. Previously, the disconnected‐introductory branch explicitly did not reset allocation (the call to setAllocationStatus was commented out).

Please confirm that this broader unallocation behavior for introductory calls is intended and that it won’t disrupt downstream routing:

• CallClosureImpl.java @ lines 197–202: new inclusion of "introductory" in the ANM/unallocation logic
• Earlier in CallClosureImpl.java: "introductory" + disconnected path only reopened the call (allocation reset was commented out)
• CallAllocationImpl.java: introductory calls currently lead to deletion, not unallocation

---

244-244:

Details

❓ Verification inconclusive

Verify the logic change for further call requirement handling.

The condition changed from !obj.getIsFurtherCallRequired() to null != obj.getIsFurtherCallRequired(), which means the block will now execute for both true and false values instead of only false.

This could significantly change the behavior - please verify this is intentional and that the downstream logic correctly handles both true and false cases.

---

🏁 Script executed:

#!/bin/bash
# Description: Check what methods are called within this conditional block
# Expected: Understand what operations are performed when isFurtherCallRequired is not null

echo "=== Finding the conditional block content ==="
rg -A 20 "if \(null != obj\.getIsFurtherCallRequired\(\)\)" src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java

echo "=== Searching for other isFurtherCallRequired usage patterns ==="
rg -A 3 -B 3 "isFurtherCallRequired"

Length of output: 35298

---

Verify expanded update logic for isFurtherCallRequired

The if in CallClosureImpl.java (around line 244) now checks

if (null != obj.getIsFurtherCallRequired()) { … }

instead of

if (!obj.getIsFurtherCallRequired()) { … }

so the update block will run for both true and false (non-null) values, not only false.

Please confirm that this broader behavior is intentional and won’t break downstream logic, in particular:

• When obj.getIsFurtherCallRequired() == true, you’ll now call
  outboundCallsRepo.updateIsFurtherCallRequired…(true)
  whereas previously the update was skipped. The repository queries in OutboundCallsRepo use
  (t.isFurtherCallRequired = true OR t.isFurtherCallRequired IS NULL)
  to select records—verify that storing an explicit true versus leaving null has no unintended side-effects on scheduling.
• When obj.getIsFurtherCallRequired() == false, the update still occurs as before.

Key locations to review:

• src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (line ≈244)
• src/main/java/com/iemr/ecd/repo/call_conf_allocation/OutboundCallsRepo.java (all queries filtering on isFurtherCallRequired)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud