fix: type fix for the build issue

[5Amogh]

📋 Description

JIRA ID: AMM-1247

Captcha service script loading method return type compatibility with typescript 2.4 has been fixed in this commit

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)

Summary by CodeRabbit

• Refactor
  • Improved internal code consistency for script loading, with no impact on user-facing functionality.

[coderabbitai]

Walkthrough

The loadScript method in the CaptchaService class is updated to explicitly return a Promise<void>, and all resolve calls within this method are now invoked without an argument, aligning with the void return type. No logic or control flow is altered.

Changes

File(s)	Change Summary
src/app/services/captcha-service/captcha.service.ts	Refactored loadScript to return Promise<void> and use resolve() with no argument.

Possibly related PRs

• fix: type issue resolution #37: Also modifies the loadScript method, but changes the Promise resolution to explicitly use undefined instead of omitting the argument.
• #AMM-1247- feat: VAPT Captcha implementation #35: Introduces and implements the loadScript method in CaptchaService, directly related to the method refined in this PR.

Suggested reviewers

• snehar-nd

Poem

A promise now returns just void,
No need for undefined to be employed.
With cleaner code, the script will load,
A bunny hops down the tidy road.
TypeScript cheers, the service shines—
Simpler signatures, simpler times!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/services/captcha-service/captcha.service.ts (1)

8-19: Consider caching the in-flight promise to avoid duplicate script injections
Repeated calls to loadScript() while the first request is still pending will append multiple <script> elements to the DOM. A lightweight improvement is to cache the promise once created and reuse it for subsequent callers.

 export class CaptchaService {
   private scriptLoaded = false;
+  private scriptLoadingPromise: Promise<void> | null = null;

   loadScript(): Promise<void> {
-    return new Promise<void>((resolve, reject) => {
+    if (this.scriptLoaded) {
+      return Promise.resolve();
+    }
+    if (this.scriptLoadingPromise) {
+      return this.scriptLoadingPromise;
+    }
+
+    this.scriptLoadingPromise = new Promise<void>((resolve, reject) => {
       if (this.scriptLoaded) return resolve();
@@
       };
       document.head.appendChild(script);
     });
+
+    return this.scriptLoadingPromise;
   }
 }

This keeps the public API unchanged while preventing duplicate network requests and extraneous DOM nodes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 727afe6 and df05604.

📒 Files selected for processing (1)

• src/app/services/captcha-service/captcha.service.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/app/services/captcha-service/captcha.service.ts (1)

src/environments/environment.local.ts (1)

• environment (42-56)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build
• GitHub Check: package
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

src/app/services/captcha-service/captcha.service.ts (1)

8-11: Type-safety fix is correct and idiomatic
Changing the return type to Promise<void> and dropping the redundant undefined payload aligns with the TypeScript 2.4 constraint and cleans up the call-sites.