-
Notifications
You must be signed in to change notification settings - Fork 14
feat(elk-stack-setup): add logging.file.name ci env #27
Conversation
WalkthroughThe changes introduce a new configuration entry in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Outside diff range and nitpick comments (1)
src/main/environment/mcts_ci.properties (1)
36-37: Consider adding documentation about ELK logging setupSince this is part of the ELK stack setup, it would be helpful to document this new requirement.
Consider adding a comment explaining:
- The expected format/path for the log file name
- Any ELK-specific requirements or conventions
- Example value for the environment variable
#ELK logging file name +# Format: Specify the full path where logs should be written +# Example: HELPLINEMCTS_API_LOGGING_FILE_NAME=/var/log/helpline-mcts/api.log logging.file.name=@env.HELPLINEMCTS_API_LOGGING_FILE_NAME@
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
π Files selected for processing (1)
src/main/environment/mcts_ci.properties(1 hunks)
π Additional comments (1)
src/main/environment/mcts_ci.properties (1)
36-37: LGTM! Verify environment variable setup in CI
The new logging configuration follows the established pattern and naming conventions.
Let's verify if this environment variable is properly set up in CI:
π Description
add logging.file.name ci env
JIRA ID:
PSMRI/AMRIT#4
β Type of Change
βΉοΈ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation