fix: remove additional slashes

[drtechie]

📋 Description

JIRA ID: AMM-1491
Fix addiitonal slashes appearing in build

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of service calls by correcting URL construction for external requests.

[coderabbitai]

Walkthrough

The changes update the construction of endpoint URLs in two HTTP POST requests by removing the explicit "/" separator between the base URL and the endpoint path. No other logic, error handling, or control flow was altered in the affected service implementation.

Changes

File(s)	Change Summary
src/main/java/com/iemr/common/identity/service/rmnch/RmnchDataSyncServiceImpl.java	Modified URL construction in two HTTP POST requests by removing explicit "/" between base URL and endpoint path.

Poem

A slash once stood between the lines,
Now gone, the URLs realign.
Paths connect with seamless grace,
No extra marks to take their place.
Hopping forward, code refined—
A cleaner trail for all to find!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/main/java/com/iemr/common/identity/service/rmnch/RmnchDataSyncServiceImpl.java (2)

675-676: Ensure proper URL concatenation to avoid missing separators
The removal of the hard-coded “/” between fhir-url and getHealthID assumes that one of these property values (either the base URL ends with a slash or the path begins with one). If neither includes the separator, the resulting URL will be invalid (e.g. https://api/fhirgetHealthID). Please verify your configuration values or adopt a robust URL‐building approach (e.g., Spring’s UriComponentsBuilder or Apache HttpClient’s URIBuilder) to join segments safely.

---

768-770: Ensure proper URL concatenation to avoid missing separators
Analogous to the FHIR call, dropping the slash in the TM service URL concatenation hinges on correct slash placement in either tm-url or get-HRP-Status. Confirm that your properties include the necessary separator, or refactor to use a dedicated URL/URI builder to eliminate configuration‐dependent bugs and improve readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 71a52e5 and c3f0463.

📒 Files selected for processing (1)

• src/main/java/com/iemr/common/identity/service/rmnch/RmnchDataSyncServiceImpl.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (java)
• GitHub Check: Build_and_analyse