Skip to content

Update 1097_ci.properties #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drtechie merged 2 commits into from
May 15, 2025
Merged

Update 1097_ci.properties #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2f851
Update 1097_ci.properties
sac2kadam Dec 18, 2024
faac692
Merge branch 'develop' into develop
drtechie May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/environment/1097_ci.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# DataSource settings: set here your own configurations for the database
spring.datasource.url=@env.DATABASE_IDENTITY_URL@
spring.datasource.url=@env.DATABASE_1097_IDENTITY_URL@
Copy link

@coderabbitai coderabbitai bot Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Environment variable configuration needs to be synchronized

The change to use DATABASE_1097_IDENTITY_URL in 1097_ci.properties creates an inconsistency with common_ci.properties which still uses DATABASE_IDENTITY_URL. This could lead to connection issues as both files are part of the same project but use different environment variables for database configuration.

  • src/main/environment/1097_ci.properties uses @env.DATABASE_1097_IDENTITY_URL@
  • src/main/environment/common_ci.properties uses @env.DATABASE_IDENTITY_URL@

Either:

  1. Update common_ci.properties to use the new DATABASE_1097_IDENTITY_URL variable, or
  2. Keep using DATABASE_IDENTITY_URL in 1097_ci.properties to maintain consistency
🔗 Analysis chain

Verify the new environment variable exists in CI/CD configuration

The database URL environment variable has been changed to be more specific to the 1097 service. Please ensure that DATABASE_1097_IDENTITY_URL is properly configured in your CI environment.

Let's check for any references to both old and new environment variables:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for both old and new environment variable references
echo "Checking for environment variable references..."
rg -l "DATABASE_1097_IDENTITY_URL|DATABASE_IDENTITY_URL" --type yaml --type properties

Length of output: 228

Script:

#!/bin/bash
# Search for both old and new environment variable references without file type restrictions
echo "Checking for environment variable references..."
rg -l "DATABASE_1097_IDENTITY_URL|DATABASE_IDENTITY_URL"

# Also check for any files with similar patterns to ensure we don't miss anything
echo -e "\nChecking for similar database URL patterns..."
rg -l "DATABASE.*IDENTITY.*URL"

# List all property files to ensure we're searching in the right places
echo -e "\nListing all property files..."
fd ".*\.properties$"

Length of output: 1069

Script:

#!/bin/bash
# Let's check the content of both files that reference the database URL
echo "Content of 1097_ci.properties:"
cat src/main/environment/1097_ci.properties

echo -e "\nContent of common_ci.properties:"
cat src/main/environment/common_ci.properties

# Also check other environment files for 1097 to see the pattern
echo -e "\nChecking other 1097 environment files:"
cat src/main/environment/1097_dev.properties | grep -i "database"
cat src/main/environment/1097_test.properties | grep -i "database"
cat src/main/environment/1097_uat.properties | grep -i "database"

Length of output: 1525

spring.datasource.username=@env.DATABASE_IDENTITY_USERNAME@
spring.datasource.password=@env.DATABASE_IDENTITY_PASSWORD@
spring.datasource.driver-class-name=com.mysql.jdbc.Driver
Expand Down
Loading