Skip to content

Conversation

@drtechie
Copy link
Member

@drtechie drtechie commented Jun 4, 2025

📋 Description

JIRA ID:

Change central env variables for MMU server.

✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

Summary by CodeRabbit

  • Chores
    • Updated server endpoints for data synchronization and inventory-related services to use new environment variables, ensuring connections are made to the correct central servers. No visible changes to the user interface or workflows.

@coderabbitai
Copy link

coderabbitai bot commented Jun 4, 2025

Walkthrough

The update modifies several URL configuration properties in the common_ci.properties file, changing their environment variable references to point to new server endpoints for data synchronization and inventory transactions. No changes were made to exported or public entities; only the configuration values were updated.

Changes

File(s) Change Summary
src/main/environment/common_ci.properties Updated URL properties to use @env.MMU_CENTRAL_SERVER@ instead of @env.MMU_API@ for data sync and inventory endpoints; changed benGenUrlCentral to use @env.COMMON_API_OPEN_SYNC@ instead of @env.COMMON_API@.

Possibly related PRs

  • updating ci properties #60: Adds new central server URL properties to the same configuration file, related by context and file but focuses on different properties.
  • changing env.variable  #65: Adjusts environment variable usage in the same configuration file for similar URL properties, changing variable suffixes and references.

Suggested reviewers

  • ravishanigarapu

Poem

A hop and a skip, new URLs in tow,
The sync and the data now know where to go.
From API to Central, the endpoints align,
Configuration refreshed—oh, how divine!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60eae06 and 834c125.

📒 Files selected for processing (1)
  • src/main/environment/common_ci.properties (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (java)
🔇 Additional comments (5)
src/main/environment/common_ci.properties (5)

26-26: Update dataSyncUploadUrl to central server environment variable.

This change correctly switches the upload endpoint to use MMU_CENTRAL_SERVER. Please verify that the MMU_CENTRAL_SERVER environment variable is defined and populated in all target environments to avoid unresolved URLs at runtime.


29-29: Switch dataSyncDownloadUrl to central server.

You’ve updated the download endpoint to use MMU_CENTRAL_SERVER. Confirm that this environment variable is available in CI, staging, and production configurations.


38-38: Modify benGenUrlCentral to use COMMON_API_OPEN_SYNC.

The property now references @env.COMMON_API_OPEN_SYNC@. Ensure that this new variable is defined and documented (e.g., in README or deployment manifests), and that any automation scripts have been updated accordingly.


49-49: Redirect transactional download URL to central server.

The dataSyncTransactionDownloadUrl has been updated to point at MMU_CENTRAL_SERVER. Validate the variable’s presence in all environment configs and that the transactional path is correct.


52-52: Update processed flag update endpoint to central server.

Changed dataSyncProcessedFlagUpdate to use MMU_CENTRAL_SERVER. Please confirm this environment variable is defined across deployments and matches the expected service path.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devikasuresh20 devikasuresh20 merged commit d0679b4 into develop Jun 4, 2025
4 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants