-
Notifications
You must be signed in to change notification settings - Fork 34
Actions Update #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions Update #72
Conversation
WalkthroughThe changes update several GitHub Actions workflow files to use newer versions of key actions, including upgrading the Java setup action from version 2 to version 4 and switching the Java distribution from 'adopt' to 'temurin'. The CodeQL analysis actions are also updated to newer versions. Additionally, the README is modified to simplify the prerequisites, now listing only JDK 17 (LTS) and Maven, removing Redis, Spring Boot V2, and MySQL from the requirements. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (2)
.github/workflows/package.yml (1)
22-23: Remove trailing whitespace
YAMLlint reports trailing spaces on the- name: Checkout codeline. Eliminating the extra space will satisfy lint rules.- - name: Checkout code + - name: Checkout codeπ§° Tools
πͺ actionlint (1.7.4)
23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
πͺ YAMLlint (1.35.1)
[warning] 22-22: wrong indentation: expected 6 but found 4
(indentation)
[error] 22-22: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml (1)
42-45: Fix indentation and remove trailing spaces
YAMLlint flags incorrect indentation and trailing whitespace in thewithblock for setup-java. Align keys underwith:with two spaces and strip any trailing spaces:- with: - java-version: 17 - distribution: 'temurin' + with: + java-version: 17 + distribution: 'temurin'π§° Tools
πͺ YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)
[error] 45-45: trailing spaces
(trailing-spaces)
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (4)
.github/workflows/build-on-pull-request.yml(1 hunks).github/workflows/package.yml(1 hunks).github/workflows/sast.yml(1 hunks)README.md(0 hunks)
π€ Files with no reviewable changes (1)
- README.md
π§° Additional context used
πͺ actionlint (1.7.4)
.github/workflows/package.yml
23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
πͺ YAMLlint (1.35.1)
.github/workflows/package.yml
[error] 24-24: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)
[error] 45-45: trailing spaces
(trailing-spaces)
π Additional comments (3)
.github/workflows/build-on-pull-request.yml (1)
17-20: Upgrade Java setup action to v4 and distribution to 'temurin'
These updates align with other workflows and ensure the CI environment uses the current Temurin distribution on JDK 17. No issues detected here..github/workflows/package.yml (1)
23-29: Approve checkout and Java setup updates
Upgradingactions/checkoutto v3 andactions/setup-javato v4 with the 'temurin' distribution modernizes the CI and keeps it consistent with other workflows.π§° Tools
πͺ actionlint (1.7.4)
23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
πͺ YAMLlint (1.35.1)
[error] 24-24: trailing spaces
(trailing-spaces)
.github/workflows/sast.yml (1)
37-44: Approve CodeQL and Java setup action version upgrades
Updatinggithub/codeql-action/initandgithub/codeql-action/analyzeto v3, alongsideactions/setup-java@v4(Temurin), standardizes the CI across workflows and uses the latest supported versions.π§° Tools
πͺ YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 8 but found 10
(indentation)



π Description
JIRA ID: here
Version update of java, codeql and more to update the workflows and help them pass in PRs.
β Type of Change
βΉοΈ Additional Information
Summary by CodeRabbit