Skip to content

Conversation

@techy4shri
Copy link
Contributor

@techy4shri techy4shri commented May 4, 2025

πŸ“‹ Description

JIRA ID: here

Version update of java, codeql and more to update the workflows and help them pass in PRs.


βœ… Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ”₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ›  Refactor (change that is neither a fix nor a new feature)
  • βš™οΈ Config change (configuration file or build script updates)
  • πŸ“š Documentation (updates to docs or readme)
  • πŸ§ͺ Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • πŸš€ Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to use newer versions of key actions and switched Java distribution to 'temurin' for improved compatibility and support.
  • Documentation
    • Simplified the prerequisites in the README by listing only JDK 17 (LTS) and Maven, removing Redis, Spring Boot V2, and MySQL.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 4, 2025

Walkthrough

The changes update several GitHub Actions workflow files to use newer versions of key actions, including upgrading the Java setup action from version 2 to version 4 and switching the Java distribution from 'adopt' to 'temurin'. The CodeQL analysis actions are also updated to newer versions. Additionally, the README is modified to simplify the prerequisites, now listing only JDK 17 (LTS) and Maven, removing Redis, Spring Boot V2, and MySQL from the requirements.

Changes

Files/Paths Change Summary
.github/workflows/build-on-pull-request.yml Updated Java setup action to v4 and changed Java distribution to 'temurin'.
.github/workflows/package.yml Upgraded checkout action to v3, Java setup to v4, and switched Java distribution to 'temurin'.
.github/workflows/sast.yml Upgraded CodeQL actions to v3, Java setup to v4, and switched Java distribution to 'temurin'.
README.md Simplified prerequisites by removing Redis, Spring Boot V2, and MySQL; now lists only JDK 17 and Maven.

Possibly related PRs

Poem

In the warren of code, we hop and renew,
With Java now Temurin, and actions brand new.
The README is lighter, dependencies fewβ€”
Just JDK and Maven, for a build that’s true.
πŸ‡βœ¨
Hopping forward, our workflows align,
With every commit, the carrots taste fine!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2025

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/package.yml (1)

22-23: Remove trailing whitespace
YAMLlint reports trailing spaces on the - name: Checkout code line. Eliminating the extra space will satisfy lint rules.

-    - name: Checkout code 
+    - name: Checkout code
🧰 Tools
πŸͺ› actionlint (1.7.4)

23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

πŸͺ› YAMLlint (1.35.1)

[warning] 22-22: wrong indentation: expected 6 but found 4

(indentation)


[error] 22-22: trailing spaces

(trailing-spaces)

.github/workflows/sast.yml (1)

42-45: Fix indentation and remove trailing spaces
YAMLlint flags incorrect indentation and trailing whitespace in the with block for setup-java. Align keys under with: with two spaces and strip any trailing spaces:

-      with:
-          java-version: 17
-          distribution: 'temurin'
+      with:
+        java-version: 17
+        distribution: 'temurin'
🧰 Tools
πŸͺ› YAMLlint (1.35.1)

[warning] 43-43: wrong indentation: expected 8 but found 10

(indentation)


[error] 45-45: trailing spaces

(trailing-spaces)

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7c84b73 and 43e80d6.

πŸ“’ Files selected for processing (4)
  • .github/workflows/build-on-pull-request.yml (1 hunks)
  • .github/workflows/package.yml (1 hunks)
  • .github/workflows/sast.yml (1 hunks)
  • README.md (0 hunks)
πŸ’€ Files with no reviewable changes (1)
  • README.md
🧰 Additional context used
πŸͺ› actionlint (1.7.4)
.github/workflows/package.yml

23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

πŸͺ› YAMLlint (1.35.1)
.github/workflows/package.yml

[error] 24-24: trailing spaces

(trailing-spaces)

.github/workflows/sast.yml

[warning] 43-43: wrong indentation: expected 8 but found 10

(indentation)


[error] 45-45: trailing spaces

(trailing-spaces)

πŸ”‡ Additional comments (3)
.github/workflows/build-on-pull-request.yml (1)

17-20: Upgrade Java setup action to v4 and distribution to 'temurin'
These updates align with other workflows and ensure the CI environment uses the current Temurin distribution on JDK 17. No issues detected here.

.github/workflows/package.yml (1)

23-29: Approve checkout and Java setup updates
Upgrading actions/checkout to v3 and actions/setup-java to v4 with the 'temurin' distribution modernizes the CI and keeps it consistent with other workflows.

🧰 Tools
πŸͺ› actionlint (1.7.4)

23-23: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

πŸͺ› YAMLlint (1.35.1)

[error] 24-24: trailing spaces

(trailing-spaces)

.github/workflows/sast.yml (1)

37-44: Approve CodeQL and Java setup action version upgrades
Updating github/codeql-action/init and github/codeql-action/analyze to v3, alongside actions/setup-java@v4 (Temurin), standardizes the CI across workflows and uses the latest supported versions.

🧰 Tools
πŸͺ› YAMLlint (1.35.1)

[warning] 43-43: wrong indentation: expected 8 but found 10

(indentation)

@drtechie drtechie merged commit 9c9a262 into PSMRI:develop May 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants