Responce Change in Registration #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe change updates the success response in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant RegistrarServiceImpl
Client->>RegistrarServiceImpl: registerBeneficiary(request)
RegistrarServiceImpl->>RegistrarServiceImpl: Process registration
alt Registration successful
RegistrarServiceImpl->>Client: Return response with Beneficiary ID and BenRegID
else Registration failed
RegistrarServiceImpl->>Client: Return error response
end
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
drtechie
approved these changes
May 29, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/iemr/tm/service/registrar/RegistrarServiceImpl.java (1)
677-680: Consolidate and format the success response message
The code duplicates nearly identical response strings in both the mobile and non-mobile branches, with inconsistent punctuation/spacing. To improve maintainability and ensure uniform formatting, consider creating a single formatted message usingString.format()(orMessageFormat) and reusing it:+ // After obtaining beneficiaryID and beneficiaryRegID + String successMessage = String.format( + "Beneficiary successfully registered. Beneficiary ID: %d, BenRegID: %d", + beneficiaryID, beneficiaryRegID + ); BeneficiaryFlowStatus obj = InputMapper.gson().fromJson(comingRequest, BeneficiaryFlowStatus.class); if (obj != null && Boolean.TRUE.equals(obj.getIsMobile())) { - responseMap.put("response", "Beneficiary successfully registered. Beneficiary ID is : "+ beneficiaryID+" , BenRegID is : "+beneficiaryRegID); + responseMap.put("response", successMessage); response1.setResponse(new Gson().toJson(responseMap)); } else { int i = commonBenStatusFlowServiceImpl.createBenFlowRecord(comingRequest, beneficiaryRegID, beneficiaryID); if (i > 0) { - responseMap.put("response", "Beneficiary successfully registered. Beneficiary ID is : "+ beneficiaryID+" , BenRegID is : "+beneficiaryRegID); + responseMap.put("response", successMessage); response1.setResponse(new Gson().toJson(responseMap)); } else { response1.setError(5000, "Error in registration; please contact administrator"); } }Also applies to: 685-688
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/iemr/tm/service/registrar/RegistrarServiceImpl.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit