Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [Patch]: git config output as hashtable[] #260

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 14, 2025

Description

This pull request includes changes to the Update-ConverageReport workflow and updates to the Get-GitHubGitConfig function to return a hashtable array instead of a pscustomobject.

Changes to GitHub Actions workflow:

  • Renamed .github/workflows/Set-CoverageReport.yml to .github/workflows/Update-CoverageReport.yml and updated the job names and script references accordingly. [1] [2] [3]

Updates to Get-GitHubGitConfig.ps1 script:

  • Changed the OutputType attribute from [pscustomobject] to [object[]].
  • Improved error handling and logging when retrieving Git configuration, and refactored the script to use an array of hashtables (key value pairs) for configuration storage instead of a pscustomobject. This is to support multiple values with the same name, which git config supports.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Jan 14, 2025
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 14, 2025 19:56
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: GitConfig as hashtable[] 🩹 [Patch]: git config as hashtable[] Jan 15, 2025
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: git config as hashtable[] 🩹 [Patch]: git config output as hashtable[] Jan 15, 2025
@MariusStorhaug MariusStorhaug merged commit f5cc552 into main Jan 15, 2025
20 checks passed
@MariusStorhaug MariusStorhaug deleted the gitconfig branch January 15, 2025 13:24
Copy link
Contributor

Module [GitHub - v0.11.46] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.11.46 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant