Setup structure & workflows and add t2prep block #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add pyproject.toml * add .gitignore * add general folder structure
Add GitHub workflows and dependabot config
* change definition of system defaults * small docstring fixes in t2prep * add t1prep block * add tests for t1prep block
ckolbPTB
approved these changes
Jan 25, 2025
| *.swp | ||
| *.swo | ||
|
|
||
| # Ignore output folder |
| hooks: | ||
| - id: typos | ||
|
|
||
| - repo: https://github.com/fzimmermann89/check_all |
There was a problem hiding this comment.
Do we want to have the all-logic? In MRpro we did this for the documentation. Maybe we leave it for the moment and add it back in when we have a documentation which requires that...
| @@ -0,0 +1 @@ | |||
| <?xml version="1.0" encoding="utf-8"?><testsuites><testsuite name="pytest" errors="0" failures="0" skipped="0" tests="0" time="1.253" timestamp="2025-01-15T16:00:30.474844+01:00" hostname="i81453" /></testsuites> | |||
| Duration of the adiabatic inversion pulse (in seconds). | ||
| add_spoiler | ||
| Toggles addition of spoiler gradients after the inversion pulse. | ||
| The spoiler does not increase the total duration of the block, but limits the minimum inversion time. |
There was a problem hiding this comment.
why does it not increase the block duration?
There was a problem hiding this comment.
After reading on about the inversion_time I understand now why this does not increase the block duration.
| if seq is None: | ||
| seq = pp.Sequence(system=system) | ||
|
|
||
| # get current duration of sequence before adding T2prep block |
There was a problem hiding this comment.
Suggested change
| # get current duration of sequence before adding T2prep block | |
| # get current duration of sequence before adding T1 preparation block |
| ) -> tuple[pp.Sequence, float]: | ||
| """Add an adiabatic T1 preparation block to a sequence. | ||
|
|
||
| The adiabatic inversion pulse is a hyperbolic secant pulse with default values similar to the one used by Siemens. |
There was a problem hiding this comment.
Suggested change
| The adiabatic inversion pulse is a hyperbolic secant pulse with default values similar to the one used by Siemens. | |
| The adiabatic inversion pulse is a hyperbolic secant pulse with default values similar to the one used by vendors. |
| if tau > 0: | ||
| seq.add_block(pp.make_delay(tau)) | ||
|
|
||
| # calculate total duration of T1prep block |
There was a problem hiding this comment.
Suggested change
| # calculate total duration of T1prep block | |
| # calculate total duration of T1 preparation block |
| system | ||
| PyPulseq system limit object. Must have rf_dead_time attribute != None. | ||
| duration_180 | ||
| Duration of 180° refocussing block pulse (in seconds). The 90° pulses have half this duration. |
There was a problem hiding this comment.
Suggested change
| Duration of 180° refocussing block pulse (in seconds). The 90° pulses have half this duration. | |
| Duration of 180° refocusing block pulse (in seconds). The 90° pulses have half this duration. |
| if seq is None: | ||
| seq = pp.Sequence(system=system) | ||
|
|
||
| # get current duration of sequence before adding T2prep block |
There was a problem hiding this comment.
Suggested change
| # get current duration of sequence before adding T2prep block | |
| # get current duration of sequence before adding T2 preparation block |
| @@ -0,0 +1,112 @@ | |||
| """Tests for the MLEV-4 type T2 preparation block.""" | |||
There was a problem hiding this comment.
This file should be name test_t2prep.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.