Add form options, controller template arrays #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller/ProfileManager.php
Outdated
| ProfileController $controller, | ||
| FormFactory $formFactory | ||
| ) { | ||
| UserDiscriminator $userDiscriminator, ContainerInterface $container, |
There was a problem hiding this comment.
This change is useless and against PSR-2. Please restore previous line splitting.
There was a problem hiding this comment.
Restored.
From: Massimiliano Arione notifications@github.com
To: PUGX/PUGXMultiUserBundle PUGXMultiUserBundle@noreply.github.com
Cc: George Brooks truckeetrout@yahoo.com
Sent: Thursday, November 5, 2015 12:10 AM
Subject: Re: [PUGXMultiUserBundle] Add form options, controller template arrays (#95)
In Controller/ProfileManager.php:> @@ -36,29 +37,28 @@ class ProfileManager
* @param FormFactory $formFactory */ public function __construct(
UserDiscriminator $userDiscriminator,ContainerInterface $container,ProfileController $controller,FormFactory $formFactory- ) {
- UserDiscriminator $userDiscriminator, ContainerInterface $container,
This change is useless and against PSR-2. Please restore previous line splitting.—
Reply to this email directly or view it on GitHub.
|
Please note: ProfileManager, RegistrationManager have been checked by php-cs-fixer psr-2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to send
config.ymloptions to registration and profile forms. It also adds the ability to add business logic to registration and profile controllers. These controllers have ready access to the container, making it possible to create an array of templates based on a set of conditions. The templates array is then passed to the registration & profile templates. See the updated documentation for details.