Fix get_config to be compatible with openapi spec #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PWZER
reviewed
Sep 1, 2023
PWZER
reviewed
Sep 1, 2023
PWZER
reviewed
Sep 2, 2023
|
|
||
| version = config.get('openapi', '2.0.0') | ||
| if Version(version) >= Version('3.0.0'): |
There was a problem hiding this comment.
Why delete these? I remember it use servers in openapi version 3 rather than host.
There was a problem hiding this comment.
It used host rather than servers, it overrode every URL entry in servers with host, which is a behavior not defined at all in OpenAPI, but more importantly it prevented the standard use case of just setting a URL. If the old behavior is useful in someway, maybe it could be enabled via a configuration option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex replacement prevents using the servers directive as specified under: https://learn.openapis.org/specification/servers.html
Requiring
from packaging.version import Versionprevented me from cleanly building this package, and is a non-standard check since setuptools offerspython_requires. I used minimum 3.8 as set by tox.ini.