Skip to content

Add ESC RPM and Temperature. Add missing mode background colors #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

AlexKlimaj
Copy link
Member

This PR adds a new graph with ESC RPM if it exists in the log. Along with plotting ESC temperatures if they are present.

I also added the missing background colors for mode changes to other plots.

image

image

Copy link

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AlexKlimaj AlexKlimaj requested a review from dakejahl June 11, 2025 22:46
@dakejahl
Copy link

Good to merge

@mrpollo mrpollo merged commit 18bff4c into PX4:main Jun 12, 2025
5 checks passed
@bkueng
Copy link
Member

bkueng commented Jun 12, 2025

This broke things. Could you please do cross-testing against other logs in future?

Traceback (most recent call last):
  File "/home/ubuntu/flight_review/app/plot_app/main.py", line 230, in <module>
    plots = generate_plots(ulog, px4_ulog, db_data, vehicle_data,
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/flight_review/app/plot_app/configured_plots.py", line 644, in generate_plots
    if 'esc_count' in data_plot.dataset.data:
                      ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'data'

@AlexKlimaj
Copy link
Member Author

This broke things. Could you please do cross-testing against other logs in future?

Traceback (most recent call last):
  File "/home/ubuntu/flight_review/app/plot_app/main.py", line 230, in <module>
    plots = generate_plots(ulog, px4_ulog, db_data, vehicle_data,
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/flight_review/app/plot_app/configured_plots.py", line 644, in generate_plots
    if 'esc_count' in data_plot.dataset.data:
                      ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'data'

#312

@AlexKlimaj AlexKlimaj deleted the pr-esc-temp branch June 12, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants