-
Notifications
You must be signed in to change notification settings - Fork 684
[BugFix] fix eb5 prefix bug #5879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix eb5 prefix bug #5879
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5879 +/- ##
==========================================
Coverage ? 66.63%
==========================================
Files ? 347
Lines ? 44421
Branches ? 6825
==========================================
Hits ? 29599
Misses ? 12640
Partials ? 2182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rainyfly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是从前缀树里把这个 node 给摘除,是否需要加一个 从node.parent的孩子节点里移除
建树的时候,增加了判断是否已存在相同hash的block,如果有:保留旧block,跳过创建新block |
Motivation
当上下文缓存完全命中时,会revert 一个block的token,保证输入非空。但在 eb5 多模场景下,会导致输入缺少多模信息
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.