fixing langchain text splitter import#4981
Open
norbbrog wants to merge 1 commit intoPaddlePaddle:developfrom
Open
fixing langchain text splitter import#4981norbbrog wants to merge 1 commit intoPaddlePaddle:developfrom
norbbrog wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
|
|
norbbrog
force-pushed
the
fix_langchain_import
branch
from
ac03f56 to
440c1f6
Compare
Bobholamovic
reviewed
Feb 6, 2026
Member
Bobholamovic
left a comment
Bobholamovic
left a comment
There was a problem hiding this comment.
Please also update .precommit/check_imports.py by adding an entry to MOD_TO_DEP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing langchain text splitter import to be compatible with langchain v0 and v1 as suggested in PaddlePaddle/PaddleOCR#17186
Note that the dependency on langchain may come not through the extra dependencies of paddlex[ie] in setup.py; in that case langchain <1.0 is not enforced
should also consider using "lazy" imports to postpone importing dependencies that may not be needed. The 'is_dep_available("langchain")' triggers the imports if langchain is installed as part of a larger project, even if the functionalities of paddlex[ie] are not needed