feat: key press of slash focuses search bar#1018
Conversation
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
bglw
left a comment
There was a problem hiding this comment.
Hey @miketheman! 👋
These changes look all ok, though I will note that we're on the threshold of the 1.5.0 release, which brings an entirely new UI: https://ui.pagefind.app/
The existing "default ui" won't be removed, though it will become somewhat deprecated in favor of the new UI components.
|
Oh, that's very cool! Glancing at the docs, it doesn't look like there's an option in the new component style to have a single key press like slash, it must have a modifier? |
|
Currently yep, but that can be adjusted :) |
|
Cool, I'll have to take a look. In the meantime, if this makes it in, we could start using it on the existing UI |
Challenge accepted - first commit on #1025 does that |
First time caller, hope I got it right.
Having used search on websites and loving the keyboard focus, and recognizing that
autofocuscan solve the issue, yet introduces accessibility concerns, I thought that adding the ability to implement to opt in to a method for surfacing the feature.Happy to take some feedback, this isn't the most familiar code for me yet.