fix: Don't look for root selectors in pages without data-pagefind-body.#919
Open
shubham-padia wants to merge 1 commit intoPagefind:mainfrom
Open
fix: Don't look for root selectors in pages without data-pagefind-body.#919shubham-padia wants to merge 1 commit intoPagefind:mainfrom
shubham-padia wants to merge 1 commit intoPagefind:mainfrom
Conversation
Fixes Pagefind#918. Pagefind ignores files without data-pagefind-body from indexing, but it still looks at those files when doing the root selector check. This resulted in unnecessary warnings.
Author
|
I could not find any tests related to this specific check that I should have modified. |
Member
|
Hmm I don't think this will work as intended unfortunately. With the default settings, if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #918.
Pagefind ignores files without data-pagefind-body from indexing, but it still looks at those files when doing the root selector check. This resulted in unnecessary warnings.