Async: Do not invoke timers callbacks multiple times on io_uring backend

Pagghiu · Aug 25, 2024 · 3735432 · 3735432
1 parent 9b1b2d0
commit 3735432
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/Libraries/Async/Async.cpp b/Libraries/Async/Async.cpp
@@ -713,15 +713,21 @@ SC::Result SC::AsyncEventLoop::Internal::dispatchCompletions(SyncMode syncMode,
     switch (syncMode)
     {
     case SyncMode::NoWait: {
-        invokeExpiredTimers(loopTime);
+        if (kernelEvents.needsManualTimersProcessing())
+        {
+            invokeExpiredTimers(loopTime);
+        }
     }
     break;
     case SyncMode::ForcedForwardProgress: {
         if (expiredTimer)
         {
             expiredTimer = nullptr;
             updateTime();
-            invokeExpiredTimers(loopTime);
+            if (kernelEvents.needsManualTimersProcessing())
+            {
+                invokeExpiredTimers(loopTime);
+            }
         }
     }
     break;

diff --git a/Libraries/Async/Internal/AsyncLinux.inl b/Libraries/Async/Internal/AsyncLinux.inl
@@ -63,7 +63,9 @@ struct SC::AsyncEventLoop::Internal::KernelEvents
     {
         return true;
     }
-
+
+    bool needsManualTimersProcessing() { return isEpoll; }
+
     template <typename T, typename P> [[nodiscard]] static Result executeOperation(T&, P& p);
     // clang-format on
 };

diff --git a/Libraries/Async/Internal/AsyncPosix.inl b/Libraries/Async/Internal/AsyncPosix.inl
@@ -808,6 +808,8 @@ struct SC::AsyncEventLoop::Internal::KernelEventsPosix
 
     static bool needsSubmissionWhenReactivating(AsyncFilePoll&) { return false; }
 
+    static bool needsManualTimersProcessing() { return true; }
+
     //-------------------------------------------------------------------------------------------------------
     // File CLOSE
     //-------------------------------------------------------------------------------------------------------

diff --git a/Libraries/Async/Internal/AsyncWindows.inl b/Libraries/Async/Internal/AsyncWindows.inl
@@ -687,10 +687,9 @@ struct SC::AsyncEventLoop::Internal::KernelEvents
 
     // If False, makes re-activation a no-op, that is a lightweight optimization.
     // More importantly it prevents an assert about being Submitting state when async completes during re-activation run cycle.
-    template<typename T> static bool needsSubmissionWhenReactivating(T&)
-    {
-        return true;
-    }
+    template<typename T> static bool needsSubmissionWhenReactivating(T&) { return true; }
+
+    static bool needsManualTimersProcessing() { return true; }
 
     template <typename T, typename P> [[nodiscard]] static Result executeOperation(T&, P&) { return Result::Error("Implement executeOperation"); }
     // clang-format on