Open
Conversation
| NodeList* walker = list->head; | ||
| while (walker->next != NULL) { | ||
| walker = walker->next; | ||
| } |
There was a problem hiding this comment.
Получается, что добавление всегда только в конец и всегда за линию. Я бы как пользователь ожидал реализации за константу --- за линию можно и в произвольное место добавлять.
Comment on lines
+103
to
+104
| char* value = list->head->value; | ||
| free(list->head); |
There was a problem hiding this comment.
Но поскольку value живёт внутри структуры NodeList, то free удалит и value. Так что тут мы возвращаем уже мёртвый указатель. Это всё не падает, видимо, просто потом, что возвращаемое значение на самом деле никому не интересно.
| typedef struct List List; | ||
|
|
||
| typedef enum Error { | ||
| memoryError, |
| ok, | ||
| }Error; | ||
|
|
||
| List* createList(Error* errorCheck); |
| List* list = createList(errorCheck); | ||
| if (list == NULL) { | ||
| *errorCheck = emptyPointer; | ||
| return; |
| } | ||
| List* list = createList(&errorCheck); | ||
| if (list == NULL) { | ||
| errorCheck = emptyPointer; |
| return false; | ||
| } | ||
| clearList(list, &errorCheck); | ||
| return result; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.