Open
Conversation
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Автомат правильный. сделано не совсем то, что просили и не очень аккуратно
| #include <stdbool.h> | ||
|
|
||
| typedef enum Stage { | ||
| first, |
| fourth, | ||
| fifth, | ||
| sixth | ||
| } Stage; |
There was a problem hiding this comment.
Названия состояний не мнемоничны, не отражают их назначения и по сути ничем не лучше чисел. Как в анекдоте, const int one = 1;
Comment on lines
+32
to
+33
| if (symbol >= 'A' && symbol <= 'Z' || symbol == '+' || symbol == '-' | ||
| || symbol >= '0' && symbol <= '9' || symbol == '.' || symbol == '%') { |
There was a problem hiding this comment.
Сложные логические условия, тем более если планируется их переиспользовать, лучше выносить в функцию
Comment on lines
+22
to
+23
| char buffer[1000] = { '\0' }; | ||
| char result[10000] = { '\0' }; |
There was a problem hiding this comment.
Это вообще не нужно, задачей было по строке сказать "да/нет", возвращать что-либо не просили
| } else { | ||
| memset(buffer, 0, strlen(buffer)); | ||
| indexBuffer = 0; | ||
| stage = first; |
There was a problem hiding this comment.
Не-а, тут надо было вернуть false, потому что строка уже не соответствует регэкспу
|
|
||
| #include <stdio.h> | ||
|
|
||
| //Variable for error checking |
There was a problem hiding this comment.
Suggested change
| //Variable for error checking | |
| // Variable for error checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.