BugFix : Fixed Overflow of images in Advertisement and Venue Post modals #3204
Conversation
WalkthroughThe pull request focuses on resolving image preview and modal styling issues in the application's CSS. The changes primarily address image overflow problems in venue and advertisement modals by implementing Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/style/app.module.css (2)
4647-4664: Consider consolidating close button styles.The close button styles look good but are duplicated with
.closeButtonAdvertisementRegister. Consider creating a shared class for common close button styles.+.closeButton { + position: absolute; + top: 0px; + right: 0px; + width: 32px; + height: 32px; + background: transparent; + transform: scale(1.2); + cursor: pointer; + border-radius: 50%; + border: none; + color: var(--grey-dark); + font-weight: 600; + font-size: 16px; + transition: + background-color 0.3s, + transform 0.3s; +} + +.closeButton:hover { + transform: scale(1.1); + box-shadow: 0 4px 6px rgba(0, 0, 0, 0.2); +} -.closeButtonP { - position: absolute; - top: 0px; - right: 0px; - width: 32px; - height: 32px; - background: transparent; - transform: scale(1.2); - cursor: pointer; - border-radius: 50%; - border: none; - color: var(--grey-dark); - font-weight: 600; - font-size: 16px; - transition: - background-color 0.3s, - transform 0.3s; -} - -.closeButtonP:hover { - transform: scale(1.1); - box-shadow: 0 4px 6px rgba(0, 0, 0, 0.2); -} +.closeButtonP { + composes: closeButton; +}
5117-5137: Consider consolidating close button styles.The close button styles are duplicated from
.closeButtonP. Use the shared.closeButtonclass suggested above.-.closeButtonAdvertisementRegister { - position: absolute; - top: 0px; - right: 0px; - width: 32px; - height: 32px; - background: transparent; - transform: scale(1.2); - cursor: pointer; - border-radius: 50%; - border: none; - color: var(--grey-dark); - font-weight: 600; - font-size: 16px; - transition: - background-color 0.3s, - transform 0.3s; -} - -.closeButtonAdvertisementRegister:hover { - transform: scale(1.1); - box-shadow: 0 4px 6px rgba(0, 0, 0, 0.2); -} +.closeButtonAdvertisementRegister { + composes: closeButton; +}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/style/app.module.css(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (2)
src/style/app.module.css (2)
4632-4641: LGTM! The overflow fix for venue modal looks good.The changes properly handle image overflow and maintain aspect ratio:
- Added
overflow: hiddento prevent content overflow- Added
object-fit: coverto maintain image aspect ratio
5100-5108: LGTM! The overflow fix for advertisement modal looks good.The changes properly handle image overflow and maintain aspect ratio:
- Added
overflow: hiddento prevent content overflow- Added
object-fit: coverto maintain image aspect ratio
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3204 +/- ##
=====================================================
+ Coverage 18.70% 89.83% +71.12%
=====================================================
Files 308 329 +21
Lines 7798 8526 +728
Branches 1697 1913 +216
=====================================================
+ Hits 1459 7659 +6200
+ Misses 6241 635 -5606
- Partials 98 232 +134 ☔ View full report in Codecov by Sentry. |
|
Hello @palisadoes, I hope you're doing well. I only made changes to a CSS file, but I'm unsure why this test case is failing. Could you kindly guide me? Thank you! |
There was a problem hiding this comment.
hey @yugal07, I think it was just a flaky build, re-running the test fixed it.
palisadoes
merged commit 0acc11b
into
PalisadoesFoundation:develop-postgres
* prevented unnecessary page reload with complementary test * Update jest.config.js * Fixes #2986 - Multiple UI Updates (#3165) * UI fixes on organisation pages * Added TSDoc for Truncated Text * Added Debouncer * Update src/components/OrgListCard/OrgListCard.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Added code rabbit suggestions * Fixed test error --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactore src/screens/OrgList from jest to vitest (#3200) * Improved Code Coverage in src/components/Venues/VenueModal.tsx (#3203) * Improved Code Coverage in src/components/Venues/VenueModal.tsx * removed the ignore statements from VenueModal.tsx * Removed istanbul ignore lines. Code coverage remians 100% (#3207) * refactored src/screens/FundCampaignPledge from jest to vitest (#3208) * prettier formatting and disabled ts-specific rules for js in eslint (#3186) * Improve Code Coverage in src/screens/UserPortal/Settings/Settings.tsx (#3189) * Preventing Overflow of images in Advertisement and Venue Post modals (#3204) * improve code coverage of src/screens/EventManagement (#3149) * code coverage * jest global coverage decreased * global jest coverage * rename file problem solved * changes requested resolved * fix: update Chat section title to 'Chats' (#3216) * removed stale comment line * Revert "removed stale comment line" This reverts commit e0fa894. * removed stale comment line --------- Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com> Co-authored-by: Mehul Aggarwal <88583647+AceHunterr@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Syed Ali Ul Hasan <syedaliulhasan19@gmail.com> Co-authored-by: harshk-89 <133699216+harshk-89@users.noreply.github.com> Co-authored-by: Amaan ali <amaan.ali.ug22@nsut.ac.in> Co-authored-by: Yugal Sadhwani <yashsadhwani544@gmail.com> Co-authored-by: Pranav Nathe <93403830+pranavnathe@users.noreply.github.com> Co-authored-by: prathmesh703 <146568950+prathmesh703@users.noreply.github.com> Co-authored-by: Nivedita <141390434+Nivedita-Chhokar@users.noreply.github.com>
What kind of change does this PR introduce?
Bug Fix
Issue Number:
Fixes #3192
Did you add tests for your changes?
No
Snapshots/Videos:
Before
After
If relevant, did you update the documentation?
NA
Does this PR introduce a breaking change?
No
Images were flowing out of the venue post card and advertisement post card. Also, the close buttons were out of frame and very visually unappealing.
To fix that, i added some styling like "overflow : hidden" and "object-fit : cover" to fix the overflow problem. Moreover, i added some styling to align the close buttons on their correct position and added styling to make them more visually appealing.
Have you read the contributing guide?
Summary by CodeRabbit