Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ESLint bugs that required ts-specific rules for js functions and added prettier formatting (re-open #3184) #3229

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Fixed ESLint bugs that required ts-specific rules for js functions and added prettier formatting (re-open #3184) #3229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a7f11a
Fixed ESLint bugs that required ts-specific rules for js functions
yugal07 Jan 9, 2025
bdd13e8
Removed eslint-ignore comments and added override rule specifically f…
yugal07 Jan 16, 2025
f8d20e3
Changed the file to typescript file and added return types to avoid l…
yugal07 Jan 18, 2025
0e62ab8
adding npx to run the tsx command
yugal07 Jan 18, 2025
b25b4b2
coderabbit suggestions and ignore codeconv for this file since it is …
yugal07 Jan 18, 2025
13bddb3
removed the ignore statement
yugal07 Jan 19, 2025
0c30382
Resolved merge conflicts in package.json
yugal07 Jan 21, 2025
b026480
Merge branch 'develop-postgres' into issue-3184-reopen
yugal07 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,5 +153,14 @@
"docs/sidebars.ts",
"docs/src/**",
"docs/blog/**"
],
"overrides": [
{
"files": ["scripts/githooks/check-localstorage-usage.js"],
"rules": {
"@typescript-eslint/explicit-module-boundary-types": "off",
"@typescript-eslint/explicit-function-return-type": "off"
}
}
]
}
4 changes: 2 additions & 2 deletions scripts/githooks/check-localstorage-usage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ if (filesWithLocalStorage.length > 0) {

console.info(
'\x1b[34m%s\x1b[0m',
'\nInfo: Consider using custom hook functions.'
'\nInfo: Consider using custom hook functions.',
);
console.info(
'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n'
'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n',
);

process.exit(1);
Expand Down
Loading