Skip to content

Figma: People Page Violates The Figma Style Guide #3171 #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Figma: People Page Violates The Figma Style Guide #3171 #3274

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
997e7cb
gg
abhassen44 Dec 30, 2024
c873b7f
hh
abhassen44 Dec 30, 2024
4ba5d8a
Merge branch 'develop-postgres' of https://github.com/PalisadoesFound…
abhassen44 Dec 30, 2024
59dfb45
Merge branch 'develop-postgres' into feat/css
abhassen44 Dec 30, 2024
c28c3d8
refreshed
abhassen44 Dec 30, 2024
a377c16
gg
abhassen44 Jan 14, 2025
e0f3c6c
test
abhassen44 Jan 14, 2025
3a4eb6b
resolving-conflict
abhassen44 Jan 14, 2025
7959fbb
resolving-conflict
abhassen44 Jan 14, 2025
c597c38
resolving-design
abhassen44 Jan 14, 2025
73d0d71
resolving-design
abhassen44 Jan 14, 2025
5ad1953
css
abhassen44 Jan 14, 2025
762b6a4
css
abhassen44 Jan 14, 2025
ba82b69
css
abhassen44 Jan 14, 2025
d7ad796
css
abhassen44 Jan 14, 2025
e5c8b87
css
abhassen44 Jan 14, 2025
ef42c3a
css
abhassen44 Jan 14, 2025
2e2828b
code-rabit-reconfigaring
abhassen44 Jan 14, 2025
0a7f31e
code-rabit-reconfigaring
abhassen44 Jan 14, 2025
929ea91
code-rabit-reconfigaring
abhassen44 Jan 16, 2025
5ce3410
test
abhassen44 Jan 16, 2025
ef2fa18
test
abhassen44 Jan 16, 2025
6295d17
about
abhassen44 Jan 19, 2025
a077c6c
about
abhassen44 Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

npm run format:fix

Check warning on line 1 in .husky/pre-commit

View workflow job for this annotation

GitHub Actions / Performs linting, formatting, type-checking, checking for different source and target branch 

File ignored by default.
# npm run lint:fix
npm run lint-staged
npm run typecheck
Expand Down
1,628 changes: 1,150 additions & 478 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"graphql": "^16.9.0",
"graphql-tag": "^2.12.6",
"graphql-ws": "^5.16.0",
"gulp-header": "^1.8.9",
"history": "^5.3.0",
"i18next": "^23.15.1",
"i18next-browser-languagedetector": "^8.0.0",
Expand Down Expand Up @@ -63,8 +64,8 @@
"redux": "^5.0.1",
"redux-thunk": "^3.1.0",
"sanitize-html": "^2.13.0",
"typedoc": "^0.26.10",
"typedoc-plugin-markdown": "^4.2.10",
"typedoc": "^0.27.0",
"typedoc-plugin-markdown": "^4.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude this file from the PR. It's not a requirement of the issue

"typescript": "^5.6.3",
"vite": "^5.4.8",
"vite-plugin-environment": "^1.1.3",
Expand Down Expand Up @@ -117,10 +118,10 @@
"@babel/preset-env": "^7.26.0",
"@babel/preset-react": "^7.25.7",
"@babel/preset-typescript": "^7.26.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.0.1",
"@testing-library/user-event": "^12.1.10",
"@testing-library/dom": "^10.4.0",
"@types/inquirer": "^9.0.7",
"@types/jest": "^26.0.24",
"@types/js-cookie": "^3.0.6",
Expand All @@ -142,6 +143,7 @@
"cross-env": "^7.0.3",
"eslint": "^8.49.0",
"eslint-config-prettier": "^9.1.0",
"eslint-config-react-app": "^7.0.1",
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-jest": "^28.10.0",
"eslint-plugin-prettier": "^5.2.1",
Expand Down
76 changes: 38 additions & 38 deletions src/assets/css/app.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/CheckIn/TableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const TableRow = ({
inputs.push({ name: data.name.trim() });
const pdf = await generate({ template: tagTemplate, inputs });
// istanbul ignore next
const blob = new Blob([pdf.buffer], { type: 'application/pdf' });
const blob = new Blob([pdf], { type: 'application/pdf' });
// istanbul ignore next
const url = URL.createObjectURL(blob);
// istanbul ignore next
Expand Down
10 changes: 5 additions & 5 deletions src/components/CollapsibleDropdown/CollapsibleDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,21 @@ const collapsibleDropdown = ({
<>
<Button
variant={showDropdown ? 'success' : ''}
className={showDropdown ? 'text-white' : 'text-secondary'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

className={showDropdown ? 'text-black' : 'text-secondary'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

onClick={(): void => setShowDropdown(!showDropdown)}
aria-expanded={showDropdown}
data-testid="collapsible-dropdown"
>
<div className={styles.iconWrapper}>
<IconComponent
name={name}
fill={showDropdown ? 'var(--bs-white)' : 'var(--bs-secondary)'}
fill={showDropdown ? 'var(--bs-black)' : 'var(--bs-secondary)'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

/>
</div>
{tCommon(name)}
<i
className={`ms-auto fa
${showDropdown ? 'var(--bs-white)' : 'var(--bs-secondary)'}
${showDropdown ? 'var(--bs-black)' : 'var(--bs-secondary)'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

${showDropdown ? 'fa-chevron-up' : 'fa-chevron-down'}
`}
/>
Expand All @@ -74,7 +74,7 @@ const collapsibleDropdown = ({
variant={isActive === true ? 'success' : 'light'}
size="sm"
className={`${styles.collapseBtn} ${
isActive === true ? 'text-white' : 'text-secondary'
isActive === true ? 'text-black' : 'text-secondary'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

}`}
onClick={(): void => {
navigate(url);
Expand All @@ -88,7 +88,7 @@ const collapsibleDropdown = ({
<div className="ms-auto">
<i
className={`fa me-2 fa-chevron-right ${
isActive === true ? 'text-white' : 'text-secondary'
isActive === true ? 'text-black' : 'text-secondary'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

}`}
/>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/LeftDrawer/LeftDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@ const leftDrawer = ({
<Button
variant={isActive === true ? 'success' : ''}
className={`${
isActive === true ? 'text-white' : 'text-secondary'
isActive === true ? 'text-black' : 'text-secondary'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

}`}
data-testid="rolesBtn"
>
<div className={styles.iconWrapper}>
<RolesIcon
fill={`${
isActive === true
? 'var(--bs-white)'
? 'var(--bs-black)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

: 'var(--bs-secondary)'
}`}
/>
Expand All @@ -118,7 +118,7 @@ const leftDrawer = ({
<Button
variant={isActive === true ? 'success' : ''}
className={`${
isActive === true ? 'text-white' : 'text-secondary'
isActive === true ? 'text-black' : 'text-secondary'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use hard coded colors
  2. Make this file use CSS exclusively from src/style/app.module.css, with the exception of package based CSS.
  3. Delete the CSS file in the directory of this file. Make the file exclusively use CSS from src/style/app.module.css
  4. Use no CSS in assets/css/app.css
  5. This will help with future attempts to having Dark Mode
  6. Use a variable from src/style/app.module.css .
  7. Use a variable name that describes the function of the color and not the color itself. For example --search-button-bg is much better than --light-blue

}`}
data-testid="communityProfileBtn"
>
Expand Down
Loading
Loading