Refactor CSS files in src/components/RequestsTableItem #3410
Conversation
WalkthroughThis pull request focuses on refactoring CSS files for the RequestsTableItem component, moving from a component-specific CSS module to the global Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3410 +/- ##
=====================================================
+ Coverage 7.89% 89.74% +81.84%
=====================================================
Files 312 334 +22
Lines 8171 8637 +466
Branches 1838 1921 +83
=====================================================
+ Hits 645 7751 +7106
+ Misses 7459 623 -6836
- Partials 67 263 +196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/default.md (1)
10-13: Improve documentation readability and clarity.The component description could be improved by:
- Adding "the" before "MemberDetail component"
- Reducing repetitive sentence beginnings
- Consolidating related information
Apply this diff to enhance readability:
-MemberDetail component is used to display the details of a user. -It also allows the user to update the details. It uses the UPDATE_USER_MUTATION to update the user details. -It uses the USER_DETAILS query to get the user details. It uses the useLocalStorage hook to store the user details in the local storage. +The MemberDetail component displays and manages user details. The component leverages UPDATE_USER_MUTATION for updates and USER_DETAILS query for data retrieval. Additionally, it utilizes the useLocalStorage hook for local storage persistence of user information.🧰 Tools
🪛 LanguageTool
[uncategorized] ~10-~10: You might be missing the article “the” here.
Context: ...ens/MemberDetail/MemberDetail.tsx#L50) MemberDetail component is used to display the detail...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[style] ~12-~12: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ER_MUTATION to update the user details. It uses the USER_DETAILS query to get the ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~13-~13: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..._DETAILS query to get the user details. It uses the useLocalStorage hook to store ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/components/RequestsTableItem/RequestsTableItem.tsx (2)
120-122: Add accessibility support for the icon.The icon is purely decorative, but screen readers may read it without further context. Consider adding an ARIA attribute or a tooltip for clarity. For example:
<div className={styles.iconWrapper}> - <IconComponent name={'AddMember'} fill={'var(--bs-black)'} /> + <IconComponent + name={'AddMember'} + fill={'var(--bs-black)'} + aria-label="Accept membership request" + /> </div> {t('accept')}
135-137: Ensure consistency with accessibility guidelines.The reject button's icon usage mirrors the accept button. For consistency, provide similar accessibility accommodations by adding helpful ARIA text or ensuring the icon is truly hidden from screen readers if it’s purely decorative.
src/style/app.module.css (1)
7352-7372: Consider removing negative margins from buttons.The negative
margin-lefton buttons could cause layout issues. Consider using positive margins or padding on the parent container instead..acceptButton { background: var(--accept-button-bg); color: var(--accept-button-text); border: 0; width: 120px; height: 46px; - margin-left: -1rem; display: flex; align-items: center; } .rejectButton { background: var(--red-delete-bg); color: var(--red-delete-text); border: 0; width: 120px; height: 46px; - margin-left: -1rem; display: flex; align-items: center; }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/assets/svgs/addMember.svgis excluded by!**/*.svgsrc/assets/svgs/trashBin.svgis excluded by!**/*.svg
📒 Files selected for processing (12)
docs/docs/auto-docs/components/IconComponent/IconComponent/functions/default.md(1 hunks)docs/docs/auto-docs/components/IconComponent/IconComponent/interfaces/InterfaceIconComponent.md(1 hunks)docs/docs/auto-docs/components/RequestsTableItem/RequestsTableItem/functions/default.md(1 hunks)docs/docs/auto-docs/components/RequestsTableItem/RequestsTableItem/interfaces/InterfaceRequestsListItem.md(2 hunks)docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/default.md(1 hunks)docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/getLanguageName.md(1 hunks)docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/prettyDate.md(1 hunks)src/components/IconComponent/IconComponent.spec.tsx(1 hunks)src/components/IconComponent/IconComponent.tsx(2 hunks)src/components/RequestsTableItem/RequestsTableItem.module.css(0 hunks)src/components/RequestsTableItem/RequestsTableItem.tsx(3 hunks)src/style/app.module.css(2 hunks)
💤 Files with no reviewable changes (1)
- src/components/RequestsTableItem/RequestsTableItem.module.css
✅ Files skipped from review due to trivial changes (6)
- docs/docs/auto-docs/components/IconComponent/IconComponent/functions/default.md
- docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/getLanguageName.md
- docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/prettyDate.md
- docs/docs/auto-docs/components/RequestsTableItem/RequestsTableItem/functions/default.md
- docs/docs/auto-docs/components/RequestsTableItem/RequestsTableItem/interfaces/InterfaceRequestsListItem.md
- docs/docs/auto-docs/components/IconComponent/IconComponent/interfaces/InterfaceIconComponent.md
🧰 Additional context used
🪛 GitHub Check: codecov/patch
src/components/IconComponent/IconComponent.tsx
[warning] 157-157: src/components/IconComponent/IconComponent.tsx#L157
Added line #L157 was not covered by tests
[warning] 161-161: src/components/IconComponent/IconComponent.tsx#L161
Added line #L161 was not covered by tests
🪛 LanguageTool
docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/default.md
[uncategorized] ~10-~10: You might be missing the article “the” here.
Context: ...ens/MemberDetail/MemberDetail.tsx#L50) MemberDetail component is used to display the detail...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[style] ~12-~12: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ER_MUTATION to update the user details. It uses the USER_DETAILS query to get the ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~13-~13: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..._DETAILS query to get the user details. It uses the useLocalStorage hook to store ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (8)
docs/docs/auto-docs/screens/MemberDetail/MemberDetail/functions/default.md (1)
9-9: LGTM!The function definition location has been correctly updated to reflect the changes in the source file.
src/components/RequestsTableItem/RequestsTableItem.tsx (2)
11-11: Centralizing CSS.Importing from a shared/global CSS file is a good move for reducing duplication. Ensure that the class names are unique enough to avoid accidental overrides or collisions in this global style.
12-12: Icon component import.Importing the
IconComponentis a clean approach. Check that you have adequate test coverage to confirm that icons are displayed as expected in different scenarios (e.g., invalid names, missing props).src/style/app.module.css (2)
7329-7351: LGTM! Table layout styles are well-structured.The table cell styles provide consistent padding and alignment for good readability.
7374-7402: LGTM! Responsive design is well-implemented.The media queries provide appropriate adjustments for different screen sizes, with good mobile support.
src/components/IconComponent/IconComponent.spec.tsx (1)
95-102: AddMember & TrashBin test IDs look good.Both new entries align with existing naming conventions and should be picked up in the loop-based test. Good job extending coverage to these newly introduced icons.
src/components/IconComponent/IconComponent.tsx (2)
22-23: Icon imports are consistent.These new imports follow the same pattern as other SVG icons. No issues are apparent.
156-163: Investigate coverage discrepancy for AddMember & TrashBin icons.Despite the test loop referencing these icons, the coverage tool notes lines 157 and 161 as untested. This may be a false positive or a coverage configuration anomaly. Double-check that these switch cases are being exercised in your test runner.
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 157-157: src/components/IconComponent/IconComponent.tsx#L157
Added line #L157 was not covered by tests
[warning] 161-161: src/components/IconComponent/IconComponent.tsx#L161
Added line #L161 was not covered by tests
|
Please have a look and let me know if any further changes are required |
|
@dhanagopu PTAL |
|
|
Ok sir I will upgrade it |
|
|
|
What kind of change does this PR introduce?
Added css to global css file, added svg's for accept and reject button in RequestsTableItem
Issue Number:
Fixes #3338
Snapshots/Videos:
Unfortunately I was unable to upload video in my PR so here is the link: https://drive.google.com/file/d/17s9cxRduLIOTrSy23rCN9Bhoi-fV4MC6/view?usp=sharing
Checklist
CodeRabbit AI Review
Test Coverage
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Style Changes
Documentation
Refactor