Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding users in the documentation #3238

Conversation

NishantSinghhhhh
Copy link

@NishantSinghhhhh NishantSinghhhhh commented Feb 17, 2025

What kind of change does this PR introduce?

Feature

Issue Number: : #3225

Snapshots/Videos:

Screencast.from.2025-02-18.00-42-31.webm

I have added the users in this table ,

Screenshot from 2025-02-18 00-48-59

If relevant, did you update the documentation?

Yes, I have added the new users to the documentation.

Summary
This PR adds 15 new users (administrators and regular users) to the documentation, ensuring that they are properly recorded and referenced.

Does this PR introduce a breaking change?

No

Checklist

CodeRabbit AI Review

  • I have reviewed and addressed all critical issues flagged by CodeRabbit AI
  • I have implemented or provided justification for each non-critical suggestion
  • I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

  • I have written tests for all new changes/features
  • I have verified that test coverage meets or exceeds 95%
  • I have run the test suite locally and all tests pass

Other information

This update ensures that all user roles and credentials are well documented for reference.

Have you read the contributing guide?

Yes

Summary by CodeRabbit

  • Documentation

    • Updated testing documentation with an expanded list of sample login credentials and improved presentation.
  • New Features

    • Enhanced GraphQL API functionality by introducing new endpoints for managing tag and organization data.

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Copy link

coderabbitai bot commented Feb 17, 2025

Walkthrough

The changes update the developer documentation and extend GraphQL API definitions. The documentation file now features an improved table header and expanded sample database credentials, listing 12 entries for both Administrator and Regular user accounts. Separately, the GraphQL module has been enhanced with three new operations—a query for retrieving tag details, a mutation for creating a tag, and a query for fetching organization information.

Changes

File(s) Change Summary
docs/.../developer-resources/testing.md Modified table header formatting and expanded sample credentials from one entry to 12 entries, including multiple Administrator and Regular user accounts.
test/.../gql.tada-cache.d.ts Added new GraphQL operations in the setupCache interface: query tag, mutation CreateTag, and query Organization with specified input and return types.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant GraphQL_API as GraphQL API
    participant DB as Database

    Client->>GraphQL_API: Query tag(input: QueryTagInput!)
    GraphQL_API->>DB: Retrieve tag details
    DB-->>GraphQL_API: Tag data (id, name, organization)
    GraphQL_API-->>Client: Return tag response

    Client->>GraphQL_API: Mutation CreateTag(input: MutationCreateTagInput!)
    GraphQL_API->>DB: Create new tag
    DB-->>GraphQL_API: New tag info (id, name, createdAt, organization)
    GraphQL_API-->>Client: Return CreateTag response

    Client->>GraphQL_API: Query Organization(input: QueryOrganizationInput!, first: Int!)
    GraphQL_API->>DB: Fetch organization details
    DB-->>GraphQL_API: Organization data (id, name, members)
    GraphQL_API-->>Client: Return Organization response
Loading

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

  • palisadoes
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.48%. Comparing base (8e9a5e1) to head (67e6856).
Report is 1 commits behind head on develop-postgres.

Additional details and impacted files
@@                Coverage Diff                @@
##           develop-postgres    #3238   +/-   ##
=================================================
  Coverage             45.48%   45.48%           
=================================================
  Files                   455      455           
  Lines                 33935    33935           
  Branches                757      757           
=================================================
  Hits                  15435    15435           
  Misses                18496    18496           
  Partials                  4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3c51e8 and 5014e3c.

📒 Files selected for processing (2)
  • docs/docs/docs/developer-resources/testing.md (1 hunks)
  • test/routes/graphql/gql.tada-cache.d.ts (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/docs/docs/developer-resources/testing.md

19-19: Bare URL used
null

(MD034, no-bare-urls)


20-20: Bare URL used
null

(MD034, no-bare-urls)


21-21: Bare URL used
null

(MD034, no-bare-urls)


22-22: Bare URL used
null

(MD034, no-bare-urls)


23-23: Bare URL used
null

(MD034, no-bare-urls)


24-24: Bare URL used
null

(MD034, no-bare-urls)


25-25: Bare URL used
null

(MD034, no-bare-urls)


26-26: Bare URL used
null

(MD034, no-bare-urls)


27-27: Bare URL used
null

(MD034, no-bare-urls)


28-28: Bare URL used
null

(MD034, no-bare-urls)


29-29: Bare URL used
null

(MD034, no-bare-urls)


30-30: Bare URL used
null

(MD034, no-bare-urls)


31-31: Bare URL used
null

(MD034, no-bare-urls)


32-32: Bare URL used
null

(MD034, no-bare-urls)


33-33: Bare URL used
null

(MD034, no-bare-urls)


34-34: Bare URL used
null

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Run tests for talawa api
  • GitHub Check: Analyse Code With CodeQL (typescript)
🔇 Additional comments (1)
test/routes/graphql/gql.tada-cache.d.ts (1)

47-52: Well-structured GraphQL type definitions!

The new GraphQL operations are well-defined with proper input types and return fields:

  • tag query for retrieving tag details
  • CreateTag mutation for creating new tags
  • Organization query with paginated members list

@NishantSinghhhhh
Copy link
Author

@palisadoes , Sir Do tell me what changes do I need to do in the documentation , for making this PR merge , I have tested all the users They are present in the postgres database and I am able to log In with them

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 17, 2025
@palisadoes
Copy link
Contributor

Are any of the regular users members of organizations? If so, please add that information.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are any of the regular users members of organizations? If so, please add that information.
  2. Exclude this file from the PR
    • test/routes/graphql/gql.tada-cache.d.ts

@NishantSinghhhhh
Copy link
Author

Okay will make these changes and commit the changes

@NishantSinghhhhh
Copy link
Author

@palisadoes , I have checked each regular user , none of them is a part of any organisation

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this file from the PR

  • test/routes/graphql/gql.tada-cache.d.ts

@NishantSinghhhhh
Copy link
Author

NishantSinghhhhh commented Feb 18, 2025

@palisadoes Sir , done

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes palisadoes merged commit 84562a3 into PalisadoesFoundation:develop-postgres Feb 18, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants