-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for access_request_screen_test.dart #2223
Write tests for access_request_screen_test.dart #2223
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting errors.
@noman2002 Sure sir |
@noman2002 Sir can you please guide me by exactly what I have to do regarding "Fix Formatting errors". |
I'm going to close this PR. Please resubmit when you are ready. It's a learning process. |
What kind of change does this PR introduce?
This change included the Unittest for access_request_screen.dart
Issue Number: #2151
Fixes #2151
Did you add tests for your changes?
Yes I have added tests for SendAccessRequest Widget in the access_request_screen.dart file
Snapshots/Videos: Test coverage
![Screenshot (350)](https://private-user-images.githubusercontent.com/101632079/288852099-603073c4-4dca-4a42-aafd-90db2cbaba5c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODYzNTcsIm5iZiI6MTczOTE4NjA1NywicGF0aCI6Ii8xMDE2MzIwNzkvMjg4ODUyMDk5LTYwMzA3M2M0LTRkY2EtNGE0Mi1hYWZkLTkwZGIyY2JhYmE1Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQxMTE0MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMDVkNzZlNTBhNmMyYTkxMmJjNTk2NmJlYjcxMmU1NDllYWJmMTdmMGI1YjQ2MDY4ZTk3ZDA3YWZjNzQxOWUxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.o1q_DbKggzv2k-gN6oVohvnrlz1BaFxvivc9-TsoDZ8)
Summary
Tests for access_request_screen are created for which files access_request_screen_test.dart, test_helper.dart and test_helper.mocks.dart are created and updated respectively.
The test_helper is updated for AccessRequestScreenViewModel class and correspondingly the test_helper.mocks.dart is updated on calling the build_runner command.
Does this PR introduce a breaking change?
No, this does not introduce any major changes to the codebase.
Have you read the contributing guide?
Yes, I have followed the guidelines.