-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x-codeSamples load when switching language tabs #707
Fix x-codeSamples load when switching language tabs #707
Conversation
Visit the preview URL for this PR (updated for commit 7398453): https://docusaurus-openapi-36b86--pr707-wrynrwd6.web.app (expires Thu, 22 Feb 2024 15:20:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Hi @lucasassisrosa, I noticed that I see an empty code snippet sometimes on first load/render. A reload seems to always correct the issue. |
thanks. Let me check to fix that |
@sserrata I tried the following scenarios on the PR Preview and couldn't replicate the empty code snippet issue:
Could you share the scenario that uncovers the issue? |
9fa5b05
to
d1e0831
Compare
Maybe it's an issue with the localStorage |
Description
Use merged languages to have updated set of languages on change language and code tabs
Motivation and Context
Fix an issue when switching from a non custom code sample language tab to a custom code sample one
How Has This Been Tested?
https://docusaurus-openapi-36b86--pr660-xou63k6x.web.app/petstore/add-pet, switching from Java to PHP for example
Types of changes
Checklist