Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add possibility to define dicts w/o values in checks and report #101

Merged
merged 6 commits into from
Aug 10, 2023
Merged

fix: add possibility to define dicts w/o values in checks and report #101

merged 6 commits into from
Aug 10, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Jul 28, 2023

Description

Add flexibility to define a check or report state with key: None format, which equals YAML's key:

Motivation and Context

see description in #100

How Has This Been Tested?

Existing python code was checked (Examples)

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@FoSix FoSix linked an issue Jul 28, 2023 that may be closed by this pull request
add a possibility to specify empty dicts in ConfigParser #100
Closed
@FoSix FoSix added bug Something isn't working codebase Code related issues labels Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
784 779 99% 95% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
panos_upgrade_assurance/check_firewall.py 99% 🟢
panos_upgrade_assurance/snapshot_compare.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 3773da3 by action🐍

alperenkose
alperenkose requested changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the coverage.xml need to be removed.

coverage.xml Outdated Show resolved Hide resolved
@FoSix FoSix requested a review from alperenkose August 7, 2023 10:29
@FoSix FoSix force-pushed the 100-add-a-possibility-to-specify-empty-dicts-in-configparser branch from 82f140c to 3773da3 Compare August 7, 2023 10:31
alperenkose
alperenkose approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this.

@FoSix FoSix merged commit 592f0d0 into main Aug 10, 2023
7 checks passed
@FoSix FoSix deleted the 100-add-a-possibility-to-specify-empty-dicts-in-configparser branch August 10, 2023 09:50
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@semantic-release-bot
chore(release): 0.1.4
fa6931e 
## [0.1.4](v0.1.3...v0.1.4) (2023-08-10)

### Features

* **check:** feat check for running jobs ([#104](#104)) ([1107dc4](1107dc4))

### Bug Fixes

* add possibility to define dicts w/o values in checks and report ([#101](#101)) ([592f0d0](592f0d0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenkose alperenkose alperenkose approved these changes

@adambaumeister adambaumeister Awaiting requested review from adambaumeister adambaumeister is a code owner

@horiagunica horiagunica Awaiting requested review from horiagunica horiagunica is a code owner

Assignees
No one assigned
Labels
bug Something isn't working codebase Code related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a possibility to specify empty dicts in ConfigParser
2 participants
@FoSix @alperenkose