Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add YAML as examples #103

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Jul 31, 2023

Description

Add YAML formatted examples next to Python code

Motivation and Context

see #97

How Has This Been Tested?

Tested on a local pan.dev build

Screenshots (if appropriate)

Types of changes

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
780 775 99% 95% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f237cdc by action🐍

@github-actions
Copy link

A Preview PR in PanDev repo has been created. You can view it here.

file Outdated Show resolved Hide resolved
Copy link
Collaborator

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I'm thinking if we shall also include a reference to the pan-os ansible collection, otherwise it might not make sense for the users why yaml examples are provided.

@FoSix
Copy link
Contributor Author

FoSix commented Aug 4, 2023

It looks good. I'm thinking if we shall also include a reference to the pan-os ansible collection, otherwise it might not make sense for the users why yaml examples are provided.

Yes, but the question is where. We have this text. Maybe somewhere here?

On the other hand, we already have this

@FoSix FoSix force-pushed the 97-do-config-examples-in-two-formats-python-current-and-yaml-for-ansible-use branch from faf7ffa to 90d2387 Compare August 4, 2023 09:52
@alperenkose
Copy link
Collaborator

Yes, but the question is where. We have this text. Maybe somewhere here?

On the other hand, we already have this

Exactly, I think we can add it following that line on the main page, sth like below perhaps?

They depend on pan-os-python libraries and therefore are quite easy to fit into the PanOS Ansible modules collection. Equivalent yaml configurations are provided in the documentation as a reference to use with the PanOS Ansible modules collection.

@FoSix
Copy link
Contributor Author

FoSix commented Aug 10, 2023

Yes, but the question is where. We have this text. Maybe somewhere here?
On the other hand, we already have this

Exactly, I think we can add it following that line on the main page, sth like below perhaps?

They depend on pan-os-python libraries and therefore are quite easy to fit into the PanOS Ansible modules collection. Equivalent yaml configurations are provided in the documentation as a reference to use with the PanOS Ansible modules collection.

I've added that line.

@FoSix FoSix requested a review from alperenkose August 10, 2023 09:50
@FoSix FoSix merged commit 9a65d7f into main Aug 10, 2023
7 checks passed
@FoSix FoSix deleted the 97-do-config-examples-in-two-formats-python-current-and-yaml-for-ansible-use branch August 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do config examples in two formats: python (current) and yaml (for ansible use)
2 participants