Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check for April PAN-OS Certificate Advisory #143

Merged
merged 11 commits into from
Jan 28, 2024
Merged

feat: Check for April PAN-OS Certificate Advisory #143

merged 11 commits into from
Jan 28, 2024

Conversation

adambaumeister
Copy link
Collaborator

Description

Solves #142 by adding the relevant health check and associated tests.

@adambaumeister adambaumeister linked an issue Jan 15, 2024 that may be closed by this pull request
Health check: April Certificate issue #142
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1056 1036 98% 95% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
panos_upgrade_assurance/check_firewall.py 97% 🟢
panos_upgrade_assurance/firewall_proxy.py 99% 🟢
panos_upgrade_assurance/utils.py 98% 🟢
TOTAL 98% 🟢

updated for commit: d51dc74 by action🐍

@adambaumeister adambaumeister changed the title 142 health check april certificate issue feat: Check for April PAN-OS Certificate Advisory Jan 16, 2024
@github-actions GitHub Actions
Copy link

A Preview PR in PanDev repo has been created. You can view it here.

@adambaumeister adambaumeister marked this pull request as ready for review January 16, 2024 02:29
horiagunica
horiagunica approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍

alperenkose
alperenkose reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly cosmetic and conventional updates added in comments

examples/readiness_checks/run_health_checks.py Outdated Show resolved Hide resolved
examples/readiness_checks/run_health_checks.py Outdated Show resolved Hide resolved
panos_upgrade_assurance/utils.py Outdated Show resolved Hide resolved
panos_upgrade_assurance/check_firewall.py Show resolved Hide resolved
tests/test_check_firewall.py Outdated Show resolved Hide resolved
panos_upgrade_assurance/check_firewall.py Outdated Show resolved Hide resolved
panos_upgrade_assurance/check_firewall.py Outdated Show resolved Hide resolved
panos_upgrade_assurance/check_firewall.py Show resolved Hide resolved
panos_upgrade_assurance/check_firewall.py Show resolved Hide resolved
@alperenkose alperenkose merged commit af94d0e into main Jan 28, 2024
7 checks passed
@alperenkose alperenkose deleted the 142-health-check-april-certificate-issue branch January 28, 2024 11:51
@alperenkose alperenkose restored the 142-health-check-april-certificate-issue branch January 28, 2024 11:51
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@semantic-release-bot
chore(release): 0.3.3
0ac5fc5 
## [0.3.3](v0.3.2...v0.3.3) (2024-01-31)

### Features

* Check for April PAN-OS Certificate Advisory ([#143](#143)) ([af94d0e](af94d0e))

### Bug Fixes

* lower packaging version dependency ([#145](#145)) ([3aefaaa](3aefaaa))
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 0.3.3 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenkose alperenkose alperenkose left review comments

@horiagunica horiagunica horiagunica approved these changes

@FoSix FoSix Awaiting requested review from FoSix

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health check: April Certificate issue
3 participants
@adambaumeister @horiagunica @alperenkose