Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lower packaging version dependency #145

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: lower packaging version dependency #145

merged 2 commits into from
Jan 25, 2024

Conversation

alperenkose
Copy link
Collaborator

Description

This PR lowers the packaging version in dependencies to increase interoperability with other packages.
Some python packages have lower packaging dependency requirements which results in a conflict to install together.

How Has This Been Tested?

Tested with examples/readiness_checks/run_health_checks.py script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1024 1004 98% 95% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 9aa5b28 by action🐍

@github-actions GitHub Actions
Copy link

A Preview PR in PanDev repo has been created. You can view it here.

horiagunica
horiagunica approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

adambaumeister
adambaumeister approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@adambaumeister adambaumeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and we discussed on slack why it is needed

@alperenkose alperenkose merged commit 3aefaaa into main Jan 25, 2024
7 checks passed
@alperenkose alperenkose deleted the lower-packaging-dependency branch January 25, 2024 10:00
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@semantic-release-bot
chore(release): 0.3.3
0ac5fc5 
## [0.3.3](v0.3.2...v0.3.3) (2024-01-31)

### Features

* Check for April PAN-OS Certificate Advisory ([#143](#143)) ([af94d0e](af94d0e))

### Bug Fixes

* lower packaging version dependency ([#145](#145)) ([3aefaaa](3aefaaa))
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 0.3.3 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambaumeister adambaumeister adambaumeister approved these changes

@horiagunica horiagunica horiagunica approved these changes

@FoSix FoSix Awaiting requested review from FoSix

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperenkose @horiagunica @adambaumeister