Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to skip locale enforcement #86

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: add option to skip locale enforcement #86

merged 1 commit into from
Jul 18, 2023

Conversation

alperenkose
Copy link
Collaborator

Description

Adds a flag to CheckFirewall to skip locale enforcement to en_US.UTF-8 which will run with the default locale settings on the host running the library.

Motivation and Context

Fixes #81

How Has This Been Tested?

Tested with local example script and ansible playbook.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@alperenkose alperenkose linked an issue Jul 17, 2023 that may be closed by this pull request
make forcing locale's optional #81
Closed
@github-actions
Copy link

A Preview PR in PanDev repo has been created. You can view it here.

FoSix
FoSix approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@alperenkose alperenkose merged commit f14371c into main Jul 18, 2023
6 checks passed
@alperenkose alperenkose deleted the 81-make-force-locales-optional branch July 18, 2023 09:33
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
@semantic-release-bot
chore(release): 0.1.2
157bdaf 
## [0.1.2](v0.1.1...v0.1.2) (2023-07-19)

### Features

* add option to skip locale enforcement ([#86](#86)) ([f14371c](f14371c))

### Bug Fixes

* snapshot comparison with no common keys ([#77](#77)) ([3e2f4f1](3e2f4f1)), closes [#82](#82) [#1](#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoSix FoSix FoSix approved these changes

@adambaumeister adambaumeister Awaiting requested review from adambaumeister adambaumeister is a code owner

@horiagunica horiagunica Awaiting requested review from horiagunica horiagunica is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make forcing locale's optional
2 participants
@alperenkose @FoSix