Skip to content

Commit

Permalink
Updated actions to use Node.js 20.7 due to mock-fs incompatibility is…
Browse files Browse the repository at this point in the history
…sues
  • Loading branch information
PantelisGeorgiadis committed Oct 5, 2023
1 parent 781d4cd commit d2425aa
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [14.x, 16.x, 18.x, 20.7]

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions test/Dataset.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('Dataset', () => {

it('should correctly read and write DICOM part10 files', () => {
mockFs({
'fileIn.dcm': mockFs.load(path.resolve(__dirname, '../datasets/pdf.dcm')),
'fileIn.dcm': mockFs.load(path.resolve(__dirname, './../datasets/pdf.dcm')),
'fileInEmpty.dcm': '',
});

Expand Down Expand Up @@ -119,9 +119,7 @@ describe('Dataset', () => {
});

it('should keep private tags which are parsed in via a nameMap', () => {
mockFs({
'fileIn.dcm': mockFs.load(path.resolve(__dirname, '../datasets/pdf.dcm')),
});
mockFs();

const elements1 = {
SOPClassUID: StorageClass.SecondaryCaptureImageStorage,
Expand Down Expand Up @@ -159,7 +157,7 @@ describe('Dataset', () => {

it('should correctly read and write DICOM part10 files asynchronously', () => {
mockFs({
'fileIn.dcm': mockFs.load(path.resolve(__dirname, '../datasets/pdf.dcm')),
'fileIn.dcm': mockFs.load(path.resolve(__dirname, './../datasets/pdf.dcm')),
'fileInEmpty.dcm': '',
});

Expand Down

0 comments on commit d2425aa

Please sign in to comment.