Skip to content

Feat/final deliverable #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

PaolaSantolloV
Copy link
Owner

Description

This PR contain the final deliverable.

  • Add some test to the components
  • Fix the issue in the Cart

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Tests (Adding missing tests or correcting existing tests)

How should this be tested?

In your terminal run npm install after that npm run start, now you can see the page on localhost:3000
To run the test npm run test, if you want to watch the coverage npm run test a -- --coverage.

What is the deliverable?

Final deliverable

##Screenshots and links
netlify link : https://nostalgic-archimedes-7c817a.netlify.app/

Checklist

  • I added the necessary documentation, if appropriate.
  • [x ] I added tests to prove that my fix is effective or my deliverable works.
  • I reviewed existing Pull Requests before submitting mine.
  • I have commented my code, particularly in hard-to-understand areas

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for nostalgic-archimedes-7c817a ready!

🔨 Explore the source changes: 6a63eea

🔍 Inspect the deploy log: https://app.netlify.com/sites/nostalgic-archimedes-7c817a/deploys/621554067c66320007036999

😎 Browse the preview: https://deploy-preview-5--nostalgic-archimedes-7c817a.netlify.app

@JCoronaWize
Copy link

Thank you for the update. In case you get the chance to continue working with this I suggest you to:
Add a context in order to manage the quantity of products in cart, this will also allow us to update the quantity on the icon when we are on the products page.
When updating the cart it may be worth using "sort" when creating the array to prevent changing the items order when the quantity gets updated.
If you add a test regarding the final criteria, please update the PR with which criteria and where (file) it's being handled, in order to make it easier to find
Keep going 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants