Skip to content

Conversation

@R00tB33rMan
Copy link
Contributor

This PR covers the remaining outdated dependencies (and has been tested). It also reimplements the strictness of checkstyle not only in a general sense but also for packet-oriented classes. I simply believe that the packet-driven classes should be subject to checkstyle to ensure any future changes made or added to said classes don’t fall behind in regards to codestyle, as some other classes have represented.

Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this upstream! This won't have any bearing on merging, but just curious if those docs are hand-written or generated 👀

@R00tB33rMan
Copy link
Contributor Author

Thanks for bringing this upstream! This won't have any bearing on merging, but just curious if those docs are hand-written or generated 👀

Thanks for the comment! I’d say about 40% of them were generated; however, I spent a good sum of time ensuring they at least made sense but I’ll make sure to clean everything up when I’m awake again. Took me a good sum of hours to whip this all up haha. Appreciate the kindness here!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several core dependencies and tightens style enforcement, while adding extensive Javadoc and minor cleanups across proxy protocol packets and the public API. It also makes packet-oriented classes subject to Checkstyle by removing previous exclusions and documenting their behavior more thoroughly.

Changes:

  • Bump various libraries (Netty, fastutil, JUnit, Checkstyle, toml4j) and update Javadoc configuration to target Java 21.
  • Remove the Checkstyle exclusion for proxy protocol packets and reformat/annotate many packet, chat, and brigadier-related classes to satisfy stricter style rules.
  • Add and refine Javadoc for many API types (events, networking, player/server info, plugin metadata) to better document behavior and extension points.

Reviewed changes

Copilot reviewed 183 out of 185 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
proxy/src/main/resources/default-velocity.toml Minor whitespace/comment cleanup in the default configuration.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/TitleTimesPacket.java Adds class-level Javadoc describing timing-related title packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/TitleTextPacket.java Documents the packet role for sending main title text.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/TitleSubtitlePacket.java Documents handling of subtitle content for titles.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/TitleClearPacket.java Adds Javadoc explaining semantics of clearing titles.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/TitleActionbarPacket.java Adds documentation around action bar title packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/LegacyTitlePacket.java Documents legacy title behavior and tweaks a switch branch to comply with style.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/title/GenericTitlePacket.java Adds base Javadoc and refactors switch-based construction for title packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/legacyping/LegacyMinecraftPingVersion.java Documents legacy ping protocol versions.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/TagsUpdatePacket.java Adds Javadoc for tag update semantics in config packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/StartUpdatePacket.java Documents the start-update config packet and fixes parameter alignment.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/RegistrySyncPacket.java Adds detailed Javadoc for registry sync behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/KnownPacksPacket.java Refactors formatting, improves Javadoc, and clarifies record semantics.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/FinishedUpdatePacket.java Documents completion of update sequence, minor formatting fix.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/CodeOfConductPacket.java Introduces (currently incorrect) class Javadoc for the code-of-conduct packet.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/CodeOfConductAcceptPacket.java Documents the accept packet as a singleton, no logic changes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/ClientboundServerLinksPacket.java Adds Javadoc and replaces use of API ServerLink with an internal ServerLink record for encoding/decoding.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/ClientboundCustomReportDetailsPacket.java Documents the map-based custom report details packet and refactors formatting.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/config/ActiveFeaturesPacket.java Javadoc describing active feature communication, no behavioral change.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/UnsignedPlayerCommandPacket.java Adds class Javadoc and reworks toString to use consistent concatenation style.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionPlayerCommandPacket.java Adds extensive Javadoc, adjusts imports/order, wraps long ternary, and documents nested signature classes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionPlayerChatPacket.java Documents session chat packet responsibilities and withLastSeenMessages helper.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionCommandHandler.java Adds Javadoc explaining command handler responsibilities and constructor parameters.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionChatHandler.java Documents the session chat handler and moves imports to match style.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionChatBuilder.java Adds Javadoc for the session-specific chat builder subclass.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/legacy/LegacyCommandHandler.java Documents the legacy command handler and wraps a long invocation info construction for readability.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/legacy/LegacyChatPacket.java Adds class Javadoc and clarifies a swallowed NumberFormatException via a comment.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/legacy/LegacyChatHandler.java Adds basic handler Javadoc, no logic changes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/legacy/LegacyChatBuilder.java Documents the legacy chat builder purpose.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/keyed/KeyedPlayerCommandPacket.java Adds high-level Javadoc around keyed command packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/keyed/KeyedPlayerChatPacket.java Documents responsibilities and fields for keyed chat packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/keyed/KeyedCommandHandler.java Adds Javadoc and wraps invocation info construction; no behavioral change.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/keyed/KeyedChatHandler.java Documents handler semantics and two static helper methods for invalid signed chat behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/keyed/KeyedChatBuilder.java Provides Javadoc for the keyed chat builder subclass.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/builder/ChatBuilderV2.java Adds abstract builder class-level Javadoc.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/builder/ChatBuilderFactory.java Documents the factory and adds constructor-level Javadoc.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/SystemChatPacket.java Adds documentation for system chat packets and minor formatting fixes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/RemoteChatSession.java Documents the remote chat session implementation.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/RateLimitedCommandHandler.java Converts to a documented abstract base class with clearer control flow and no semantic change.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/PlayerChatCompletionPacket.java Documents chat completion packet roles and the inner Action enum.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/LastSeenMessages.java Adds Javadoc for constructors, encode, and toString, no functional modifications.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/CommandHandler.java Documents the generic command handler interface and improves formatting of queueCommandResult.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/ChatType.java Adds enum-level documentation and closes the class with a standard brace.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/ChatTimeKeeper.java Introduces class and method Javadoc for tracking and updating chat timestamps.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/ChatQueue.java Adds imports reordering, JavaDoc for methods including handleAcknowledgement and nested ChatState, and wraps long comments.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/ChatHandler.java Documents generic chat handler interface and its default dispatch method.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/ChatAcknowledgementPacket.java Refactors to idiomatic field visibility, adds Javadoc and toString, no logic change.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/TimeArgumentSerializer.java Adds documentation for time argument serialization.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/RegistryKeyArgumentSerializer.java Documents serializer usage for registry key arguments.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/RegistryKeyArgumentList.java Adds Javadoc for nested registry key argument types and their serializers.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/RegistryKeyArgument.java Documents the argument type semantics and usage with Brigadier.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/RegistryIdArgumentSerializer.java Documents integer registry ID argument serialization.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/ModArgumentProperty.java Adds Javadoc on mod-specific argument property behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/ArgumentPropertySerializer.java Documents the generic serializer interface for argument properties.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/ArgumentPropertyRegistry.java Adds Javadoc for the registry class and some minor formatting cleanup.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/brigadier/ArgumentIdentifier.java Documents purpose of the identifier, simplifies loop, and adjusts toString.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/UpsertPlayerInfoPacket.java Adds class and enum/inner-class documentation; no behavioral change.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/TransferPacket.java Documents transfer semantics and helper methods for constructing and reading addresses.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/TabCompleteResponsePacket.java Adds class and inner Offer Javadoc.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/TabCompleteRequestPacket.java Documents the request packet and adds a defensive getCommand Javadoc.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/StatusResponsePacket.java Adds class and accessor Javadoc, no behavior changes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/StatusRequestPacket.java Documents the status request singleton usage.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/StatusPingPacket.java Documents latency-measuring ping packet semantics.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/SetCompressionPacket.java Adds Javadoc for compression threshold packet.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerboundCustomClickActionPacket.java Documents opaque click action payload forwarding.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerboundCookieResponsePacket.java Documents key-plus-payload cookie response packets.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerLoginSuccessPacket.java Adds class and accessor Javadoc, leaving strict error handling logic intact.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerLoginPacket.java Documents constructors and key/UUID handling plus getUsername behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerDataPacket.java Adds Javadoc for description/favicon/secure chat fields and normalizes imports/braces.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/RespawnPacket.java Adds class-level and constructor Javadoc including fromJoinGame description.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ResourcePackResponsePacket.java Documents constructors, getter behavior, and refactors toString.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ResourcePackRequestPacket.java Adds Javadoc for request behavior, toServerPromptedPack, and refactors toString.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/RemoveResourcePackPacket.java Documents resource pack removal semantics and formatting.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/RemovePlayerInfoPacket.java Adds class Javadoc around removing player list entries.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/PluginMessagePacket.java Adds Javadoc and defensive getChannel docs; minor whitespace cleanup.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/PingIdentifyPacket.java Documents a simple ping-identify packet with an ID.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LoginPluginResponsePacket.java Adds Javadoc for constructors and purpose of login plugin responses.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LoginPluginMessagePacket.java Documents login plugin message payloads and channel requirements.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LoginAcknowledgedPacket.java Adds class-level docs and parameter alignment.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LegacyPlayerListItemPacket.java Documents encode behavior and inner Item helper, fixes comments and formatting.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LegacyPingPacket.java Adds class Javadoc explaining legacy ping packet semantics.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LegacyHandshakePacket.java Documents purpose of the legacy handshake packet.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/LegacyDisconnect.java Replaces suppression with proper Javadoc for the legacy disconnect record and comment formatting.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/KeepAlivePacket.java Adds class-level Javadoc for KeepAlive behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/JoinGamePacket.java Refines imports, adds a comprehensive class Javadoc, and reflows toString.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/HeaderAndFooterPacket.java Documents header/footer usage in the tab list and slightly reformats create.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/HandshakePacket.java Adds detailed Javadoc and corrects parameter alignment for expected length methods.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/EncryptionResponsePacket.java Introduces detailed Javadoc, clarifying salt versions and getter behavior.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/EncryptionRequestPacket.java Adds Javadoc describing the encryption request handshake.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/DisconnectPacket.java Adds Javadoc around reasons and state-dependent decoding; slight indentation changes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/DialogShowPacket.java Documents dialog display packet behavior and version constraints.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/DialogClearPacket.java Adds Javadoc explaining dialog clear semantics.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientboundStoreCookiePacket.java Adds class-level Javadoc for storing cookies clientside.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientboundStopSoundPacket.java Documents purpose and constructors, and normalizes annotations/import order.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientboundSoundEntityPacket.java Adds detailed Javadoc and constructor, but alters encode to make subsequent writes conditional on fixedRange.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientboundCookieRequestPacket.java Adds Javadoc for cookie request packet semantics.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/ClientSettingsPacket.java Adds extensive Javadoc for fields, constructors, and toString.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/BundleDelimiterPacket.java Documents bundling delimiter semantics, no code changes.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/BossBarPacket.java Adds rich Javadoc for factory methods and getters, and fixes a bitmask cast.
proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/AvailableCommandsPacket.java Documents role of this packet in exposing available commands.
proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java Minor Javadoc punctuation fixes on legacy byte-array helpers.
proxy/src/main/java/com/velocitypowered/proxy/event/VelocityEventManager.java Moves the private fire helper earlier in the class for clarity and removes a duplicate at the bottom.
proxy/src/main/java/com/velocitypowered/proxy/connection/player/resourcepack/handler/ResourcePackHandler.java Adds a missing blank line in Javadoc for readability.
proxy/src/main/java/com/velocitypowered/proxy/connection/player/resourcepack/handler/ModernResourcePackHandler.java Updates class-level Javadoc punctuation.
proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java Adjusts shutdown Javadoc punctuation for the helper overload.
proxy/build.gradle.kts Removes Checkstyle exclusions for proxy protocol packets and fixes comment quotes.
native/src/main/java/com/velocitypowered/natives/util/MoreByteBufUtils.java Indents switch-arm comments to comply with style, no behavior changes.
gradle/libs.versions.toml Bumps versions for Netty, Checkstyle, fastutil, and JUnit.
api/src/main/java/com/velocitypowered/api/util/ServerLink.java Adds return-value docs to factory methods and documents each built-in link type.
api/src/main/java/com/velocitypowered/api/util/ProxyVersion.java Documents getters for name, vendor, and version.
api/src/main/java/com/velocitypowered/api/util/ModInfo.java Documents default mod info, getters, and nested Mod accessors.
api/src/main/java/com/velocitypowered/api/util/GameProfile.java Adds getter Javadoc for nested Property fields.
api/src/main/java/com/velocitypowered/api/proxy/server/ServerPing.java Adds constructors/getter Javadoc throughout and sample/players/version docs, with a couple of misworded comments.
api/src/main/java/com/velocitypowered/api/proxy/server/ServerInfo.java Documents getters and relaxes final on methods/overrides.
api/src/main/java/com/velocitypowered/api/proxy/server/QueryResponse.java Adds getter and factory Javadoc for nested PluginInformation.
api/src/main/java/com/velocitypowered/api/proxy/player/TabListEntry.java Clarifies builder Javadoc about IdentifiedKey usage.
api/src/main/java/com/velocitypowered/api/proxy/player/SkinParts.java Adds Javadoc for constructor and each bitmask-based accessor.
api/src/main/java/com/velocitypowered/api/proxy/player/ResourcePackInfo.java Slightly adjusts Javadoc wording and builder method return docs.
api/src/main/java/com/velocitypowered/api/proxy/player/PlayerSettings.java Documents enum constants for chat mode, main hand, and particle status.
api/src/main/java/com/velocitypowered/api/proxy/messages/MinecraftChannelIdentifier.java Documents namespace/name getters and asKey.
api/src/main/java/com/velocitypowered/api/proxy/messages/LegacyChannelIdentifier.java Adds a getter Javadoc for the legacy channel name.
api/src/main/java/com/velocitypowered/api/proxy/crypto/KeySigned.java Adds a param description to hasExpired Javadoc, minor formatting.
api/src/main/java/com/velocitypowered/api/proxy/crypto/IdentifiedKey.java Adds Javadoc for revision semantics and accessor methods.
api/src/main/java/com/velocitypowered/api/proxy/Player.java Adds missing Javadoc details, clarifies resource-pack methods, and adjusts @inheritDoc sections.
api/src/main/java/com/velocitypowered/api/plugin/PluginDescription.java Adds an optional helper to fetch a dependency by ID with Javadoc.
api/src/main/java/com/velocitypowered/api/plugin/InvalidPluginException.java Documents all constructors.
api/src/main/java/com/velocitypowered/api/permission/Tristate.java Fixes a stray empty paragraph in the enum Javadoc.
api/src/main/java/com/velocitypowered/api/network/ProtocolVersion.java Adds Javadoc per enum constant to document supported versions and special values.
api/src/main/java/com/velocitypowered/api/network/ProtocolState.java Clarifies state Javadoc with more detail per enum value.
api/src/main/java/com/velocitypowered/api/network/ListenerType.java Documents the two listener types.
api/src/main/java/com/velocitypowered/api/network/HandshakeIntent.java Documents handshake intent constants and id.
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerUnregisteredEvent.java Adds a compact canonical constructor Javadoc.
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerRegisteredEvent.java Documents record constructor for registered server events.
api/src/main/java/com/velocitypowered/api/event/proxy/ProxyShutdownEvent.java Adds a no-arg constructor and Javadoc.
api/src/main/java/com/velocitypowered/api/event/proxy/ProxyReloadEvent.java Adds explicit constructor and minimal documentation.
api/src/main/java/com/velocitypowered/api/event/proxy/ProxyPreShutdownEvent.java Adds a documented constructor.
api/src/main/java/com/velocitypowered/api/event/proxy/ProxyPingEvent.java Documents constructor parameters for ping events.
api/src/main/java/com/velocitypowered/api/event/proxy/ProxyInitializeEvent.java Adds explicit constructor and Javadoc.
api/src/main/java/com/velocitypowered/api/event/proxy/ListenerCloseEvent.java Documents constructor and getters for close events.
api/src/main/java/com/velocitypowered/api/event/proxy/ListenerBoundEvent.java Documents constructor and getters for bound events.
api/src/main/java/com/velocitypowered/api/event/player/configuration/PlayerFinishedConfigurationEvent.java Adds linking Javadoc about protocol state post-configuration.
api/src/main/java/com/velocitypowered/api/event/player/configuration/PlayerFinishConfigurationEvent.java Clarifies configuration timing semantics and backend caveats.
api/src/main/java/com/velocitypowered/api/event/player/configuration/PlayerEnteredConfigurationEvent.java Adds Javadoc tying to ProtocolState.CONFIGURATION.
api/src/main/java/com/velocitypowered/api/event/player/configuration/PlayerEnterConfigurationEvent.java Updates wording and backend caveat punctuation.
api/src/main/java/com/velocitypowered/api/event/player/configuration/PlayerConfigurationEvent.java Clarifies when this configuration event fires.
api/src/main/java/com/velocitypowered/api/event/player/ServerResourcePackSendEvent.java Adds accessor Javadoc for connection and resource pack fields.
api/src/main/java/com/velocitypowered/api/event/player/ServerResourcePackRemoveEvent.java Documents constructor parameters.
api/src/main/java/com/velocitypowered/api/event/player/ServerPreConnectEvent.java Adds Javadoc for nested Result.getServer.
api/src/main/java/com/velocitypowered/api/event/player/ServerPostConnectEvent.java Documents constructor and semantics of previousServer.
api/src/main/java/com/velocitypowered/api/event/player/ServerLoginPluginMessageEvent.java Adds accessor docs (connection, identifier, sequenceId, response helpers).
api/src/main/java/com/velocitypowered/api/event/player/ServerConnectedEvent.java Adds Javadoc to getters describing semantics.
api/src/main/java/com/velocitypowered/api/event/player/PlayerSettingsChangedEvent.java Adds constructor and getter Javadoc.
api/src/main/java/com/velocitypowered/api/event/player/PlayerResourcePackStatusEvent.java Documents deprecated and new constructors with parameters.
api/src/main/java/com/velocitypowered/api/event/player/PlayerModInfoEvent.java Documents constructor and getters.
api/src/main/java/com/velocitypowered/api/event/player/PlayerClientBrandEvent.java Adds Javadoc to getters and fixes toString formatting.
api/src/main/java/com/velocitypowered/api/event/player/PlayerChooseInitialServerEvent.java Adds getter Javadoc for player and initial server.
api/src/main/java/com/velocitypowered/api/event/player/PlayerChatEvent.java Adds getter documentation for player/message and nested result.
api/src/main/java/com/velocitypowered/api/event/player/PlayerChannelUnregisterEvent.java Adds constructor and accessor Javadoc.
api/src/main/java/com/velocitypowered/api/event/player/PlayerChannelRegisterEvent.java Adds constructor and accessor Javadoc.
api/src/main/java/com/velocitypowered/api/event/player/KickedFromServerEvent.java Documents nested result getters, including message and server components.
api/src/main/java/com/velocitypowered/api/event/player/GameProfileRequestEvent.java Adds accessor Javadoc for connection, username, original profile, and mode flag.
api/src/main/java/com/velocitypowered/api/event/player/CookieStoreEvent.java Adds Javadoc for getters and nested ForwardResult accessors.
api/src/main/java/com/velocitypowered/api/event/player/CookieRequestEvent.java Adds Javadoc for getters and ForwardResult.getKey.
api/src/main/java/com/velocitypowered/api/event/player/CookieReceiveEvent.java Adds Javadoc for getters and ForwardResult fields.
api/src/main/java/com/velocitypowered/api/event/permission/PermissionsSetupEvent.java Documents constructor, getSubject, and getProvider.
api/src/main/java/com/velocitypowered/api/event/connection/PreTransferEvent.java Documents constructor, accessors, and nested TransferResult factory/getter methods.
api/src/main/java/com/velocitypowered/api/event/connection/PreLoginEvent.java Adds Javadoc for connection, username, UUID semantics, and result helpers.
api/src/main/java/com/velocitypowered/api/event/connection/PostLoginEvent.java Documents constructor and getter.
api/src/main/java/com/velocitypowered/api/event/connection/PluginMessageEvent.java Adds accessor and helper Javadoc plus nested result factory docs.
api/src/main/java/com/velocitypowered/api/event/connection/LoginEvent.java Documents constructor and getter.
api/src/main/java/com/velocitypowered/api/event/connection/DisconnectEvent.java Refines class and enum Javadoc; documents getters clearly.
api/src/main/java/com/velocitypowered/api/event/connection/ConnectionHandshakeEvent.java Documents constructors and getters.
api/src/main/java/com/velocitypowered/api/event/command/PlayerAvailableCommandsEvent.java Adds getter Javadoc for player and root node.
api/src/main/java/com/velocitypowered/api/event/command/CommandExecuteEvent.java Adds param docs for InvocationInfo and getter docs for nested CommandResult.
api/src/main/java/com/velocitypowered/api/event/ResultedEvent.java Enhances type parameter and factory Javadoc for GenericResult and ComponentResult.
api/src/main/java/com/velocitypowered/api/event/PostOrder.java Documents semantics of each post-order enum constant.
api/src/main/java/com/velocitypowered/api/event/EventManager.java Adds type parameter Javadoc to fire as needed.
api/src/main/java/com/velocitypowered/api/event/EventHandler.java Adds generic type parameter docs and clarifies executeAsync.
api/src/main/java/com/velocitypowered/api/event/Continuation.java Documents the exception parameter for resumeWithException.
api/src/main/java/com/velocitypowered/api/command/VelocityBrigadierMessage.java Adds static factory Javadoc for tooltip messages.
api/src/main/java/com/velocitypowered/api/command/CommandSource.java Cleans up comment formatting in helper methods for sending messages.
api/src/ap/java/com/velocitypowered/api/plugin/ap/SerializedPluginDescription.java Adds Javadoc for ID pattern constants, getters, and nested Dependency.
api/src/ap/java/com/velocitypowered/api/plugin/ap/PluginAnnotationProcessor.java Adds a trivial documented constructor.
api/build.gradle.kts Switches toml4j dependency group/version, updates external Javadoc links to Java 21, and simplifies Javadoc task options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants