Skip to content

Fix dimension reading in JoinGamePacket #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xphorror wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from
+5 −1
Open

Fix dimension reading in JoinGamePacket #1734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/JoinGamePacket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,11 @@ private void decodeLegacy(ByteBuf buf, ProtocolVersion version) {
if (version.noLessThan(ProtocolVersion.MINECRAFT_1_9_1)) {
this.dimension = buf.readInt();
} else {
this.dimension = buf.readByte();
// Read as signed byte, then convert to unsigned for modded dimension IDs > 127
// (e.g. dimension 180 would be read as signed byte -76, but should be stored as 180).
// Preserve -1 (Nether) as-is since it is the only standard negative dimension ID.
int raw = buf.readByte();
this.dimension = (raw < -1) ? (raw & 0xFF) : raw;
}
if (version.noGreaterThan(ProtocolVersion.MINECRAFT_1_13_2)) {
this.difficulty = buf.readUnsignedByte();
Expand Down