Skip to content

Conversation

@PaperStrange
Copy link
Owner

Changes 🏗️

  • Close task and OKRS from project phase 6 to 7
  • For more details, refering to this file

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • [ X I have made a test plan
  • I have tested my changes according to the test plan:
    • All front-end and backend tests documentated in this folder
    • Notice for API testing, statistical front component and user jouerney testing, mock data is used
    • ...
Example test plan - Rrefering to folders mentioned above

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes refering to README.md in the project root path

PaperStrange and others added 30 commits March 23, 2025 15:05
…wright for testing and improve stability test instructions fix issue #12
…sults as artifacts; update documentation to reflect new testing processes fix issue #12
@PaperStrange PaperStrange self-assigned this May 19, 2025
@PaperStrange PaperStrange added good first issue Good for newcomers release new version release labels May 19, 2025
grep -r --include="*.js" --include="*.jsx" --include="*.ts" --include="*.tsx" "\/\* global " src/

- name: Install PowerShell
uses: bjompen/UpdatePWSHAction@v1.0.1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'TourGuideAI CI/CD Pipeline' step
Uses Step
uses 'bjompen/UpdatePWSHAction' with ref 'v1.0.1', not a pinned commit hash

- name: Set up AWS CLI
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'TourGuideAI CI/CD Pipeline' step
Uses Step
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash

- name: Set up AWS CLI
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'TourGuideAI CI/CD Pipeline' step
Uses Step
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
run: npm ci

- name: Install PowerShell
uses: bjompen/UpdatePWSHAction@v1.0.1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'TourGuideAI CI/CD Pipeline' step
Uses Step
uses 'bjompen/UpdatePWSHAction' with ref 'v1.0.1', not a pinned commit hash

# Use Dependabot to update dependencies
- name: Enable Dependabot
uses: dependabot/fetch-metadata@v1.6.0

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Dependency Updates' step
Uses Step
uses 'dependabot/fetch-metadata' with ref 'v1.6.0', not a pinned commit hash
# OWASP ZAP Baseline Scan
- name: ZAP Baseline Scan
uses: zaproxy/action-baseline@v0.7.0
uses: zaproxy/action-baseline@v0.9.0

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Security Scan' step
Uses Step
uses 'zaproxy/action-baseline' with ref 'v0.9.0', not a pinned commit hash

# License compliance scanning
- name: License Scanning
uses: fossas/fossa-action@main

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Security Scan' step
Uses Step
uses 'fossas/fossa-action' with ref 'main', not a pinned commit hash
NODE_ENV=test npm test -- tests/security/security-audit.test.js --passWithNoTests

- name: Install PowerShell
uses: bjompen/UpdatePWSHAction@v1.0.1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Stability Tests' step
Uses Step
uses 'bjompen/UpdatePWSHAction' with ref 'v1.0.1', not a pinned commit hash
if (fs.existsSync(gitignoreFile)) {
let gitignoreContent = fs.readFileSync(gitignoreFile, 'utf8');
if (!gitignoreContent.includes('generated-keys.txt')) {
fs.appendFileSync(gitignoreFile, '\n# Security keys\nscripts/generated-keys.txt\n');

Check failure

Code scanning / CodeQL

Potential file system race condition High

The file may have changed since it
was checked
.
(headerEnd < content.length ? content.substring(headerEnd) : '');

// Write updated content
fs.writeFileSync(summaryFile, content);

Check failure

Code scanning / CodeQL

Potential file system race condition High test

The file may have changed since it
was checked
.
PaperStrange and others added 11 commits May 19, 2025 22:13
…controlled format string

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…led command line

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…controlled format string

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…led command line

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…controlled format string

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…controlled format string

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Comment on lines +131 to +134
spawn('cmd', ['/c', 'start', '/b', zapPath, '-daemon', '-config', 'api.disablekey=true'], {
stdio: 'ignore',
detached: true
}).unref();

Check warning

Code scanning / CodeQL

Indirect uncontrolled command line Medium

This command depends on an unsanitized
environment variable
.
This command depends on an unsanitized
environment variable
.
@PaperStrange
Copy link
Owner Author

Securty check failures and warnings shall be addressed with issure here dynamically after this pr

@PaperStrange PaperStrange reopened this May 19, 2025
@PaperStrange PaperStrange merged commit 5a426f3 into master May 19, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers release new version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants