Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adds ClsModule.registerPlugins([new Plugin()]) #192

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

JonnyBGod
Copy link
Contributor

Enables injection of plugins from external modules for library development.

#191

@Papooch
Copy link
Owner

Papooch commented Dec 6, 2024

I guess this could work. Could you also add a test that checks if it works together with plugins registered in forRoot?

And also update the documentation here: https://papooch.github.io/nestjs-cls/plugins

@JonnyBGod JonnyBGod force-pushed the feat/register-plugins-for-feature branch from 51263f1 to ef2299d Compare December 6, 2024 15:41
@JonnyBGod
Copy link
Contributor Author

JonnyBGod commented Dec 6, 2024

Refactored the test to include a second plugin registered forRoot.
The documentation was already there. Let me know if that is not enough and would like me to document anything specifically.

@Papooch Papooch force-pushed the feat/register-plugins-for-feature branch from ef2299d to 97987ba Compare December 7, 2024 00:34
@Papooch Papooch enabled auto-merge (squash) December 7, 2024 00:34
@Papooch Papooch merged commit 11c40a0 into Papooch:main Dec 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants