-
Notifications
You must be signed in to change notification settings - Fork 340
feat: rebase migrations, remove draft-js enitrely #10640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
Signed-off-by: Matt Krick <matt.krick@gmail.com>
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- action-files.parabol.co is hardcoded multiple times and it shouldn't. Three in the new init migration and also six times in package/client/hooks/useMockPeekers.ts and twice in packages/client/types/constEnums.ts. Our storage could change of domain at any time and for private instances (PPMIs, PubSec or self-hosted) they should not use action-files.parabol.co for anything at all. Each instance should use the same file store provider and domain they are setting in their configuration and only that.
- For the new migration, you are basically inserting using the self-hosted based path and then modifying it if there is
FILE_STORE_PROVIDER
that's not local. Simple and effective enough 😸 That LGTM.
I'm going to test this in an on-demand-env
In my on-demand-env, I'm using AWS S3 as file store provider and when I started the environment for the first time, pre-deploy was executed with the following logs:
All files were uploaded to
AWS vars have the correct value, as if they hadn't no files would be uploaded to the folder |
The problem with the files not being uploaded is being fixed in #10661 |
Description
It's expected for the Migration CI test to fail. We're deleting them all!
fixes #10633
Rebases migrations since the current migrations rely on draft-js & we need to get rid of that package in order to upgrade our yarn version.
This also fixes a bug where the CDN_BASE_URL was not respected when seeding
MeetingTemplate.illustrationUrl
on an empty database. Proof of the fix below