Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add images to TipTap #10678

Merged
merged 17 commits into from
Jan 16, 2025
Merged

feat: Add images to TipTap #10678

merged 17 commits into from
Jan 16, 2025

Conversation

mattkrick
Copy link
Member

Description

This supports adding images via upload as well as embed link. Adding images via tenor/giphy/gifabol (heh) will come next

@mattkrick
feat: first pass at slashcommand menu
2fc1e41
@mattkrick
chore: bump yarnlock
6f5cf92 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into feat/slash-command-gif
203afd7
@mattkrick
Merge branch 'master' into feat/slash-command-gif
012348c
@mattkrick
add slash command menu
b96d0bb 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix: hide image upload until it's built out
09270f5 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
hide paragraph option
4e8d192 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
remove periods
3f0d714 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
feat add imageUpload extension
8db93bc 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
feat: support image uploads
a3c678a 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into feat/tiptap-images
3d719e6 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix: remove some slash commands on reflections
5c9cf74 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
feat: embed and compress images
501fa6f 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions github-actions bot added size/xl and removed size/l labels Jan 16, 2025
@mattkrick
sha256 filename to reduce storing exact dupes
d4a5226 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
make soft-breaks hard so new lines can trigger slash commands
8070ceb 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix: slashcommand menu styles
572e389 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
removed unused files
19864ce 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions github-actions bot added size/l and removed size/xl labels Jan 16, 2025
@mattkrick mattkrick merged commit e62916f into master Jan 16, 2025
6 checks passed
@mattkrick mattkrick deleted the feat/tiptap-images branch January 16, 2025 03:46
@parabol-release-bot parabol-release-bot bot mentioned this pull request Jan 16, 2025
Merged
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Closed
24 tasks
@Dschoordsch Dschoordsch mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattkrick